Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of Subgraph saucerswap-v2 code for newer version #89

Merged
merged 4 commits into from
Jun 13, 2024

Conversation

AlfredoG87
Copy link
Contributor

@AlfredoG87 AlfredoG87 commented Jun 11, 2024

Description:
There were some issues on the old subgraph code by uniswap, they did a lot of changes since the time of fork and overhauled everything, also added tests and simplified the schema as well as optimizing performance.

This PR brings that latest version of the subgraph and adapts it to SaucerSwap v2

Also adds CI tests for the subgraph.

Related issue(s):

Fixes #86
Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

…ixes some issues, provides simplification, removes a couple un-needed or little used Entities, and is more performant (faster to index)

Also adds tests, adding those tests adapted to the CI workflows of the repo as well.

Signed-off-by: Alfredo Gutierrez <[email protected]>
@AlfredoG87 AlfredoG87 requested review from a team and Nana-EC as code owners June 11, 2024 01:16
Signed-off-by: Alfredo Gutierrez <[email protected]>
@AlfredoG87 AlfredoG87 force-pushed the new-saucerswapv2-subgraph branch from eeefc92 to 82db9dc Compare June 11, 2024 01:26
…been removed, also some small nits improved

Signed-off-by: Alfredo Gutierrez <[email protected]>
…as for production environments tasks.

Signed-off-by: Alfredo Gutierrez <[email protected]>
@AlfredoG87 AlfredoG87 changed the title Update of Subgraph code for newer version Update of Subgraph saucerswap-v2 code for newer version Jun 11, 2024
@AlfredoG87 AlfredoG87 requested a review from acuarica June 12, 2024 02:39
Copy link
Contributor

@acuarica acuarica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AlfredoG87 AlfredoG87 added this to the 0.2.0 milestone Jun 13, 2024
@AlfredoG87 AlfredoG87 added the Bug A error that causes the feature to behave differently than what was expected based on design docs label Jun 13, 2024
@AlfredoG87 AlfredoG87 self-assigned this Jun 13, 2024
@AlfredoG87 AlfredoG87 merged commit 50f10ae into main Jun 13, 2024
8 checks passed
@AlfredoG87 AlfredoG87 deleted the new-saucerswapv2-subgraph branch June 13, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A error that causes the feature to behave differently than what was expected based on design docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Saucerswap-v2 Indexing Error
2 participants