Expand API acceptance tests #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to do so we need to declare Ganache as a `LOCAL_CHAINS`. Moreover, in test we need define `USE_LOCAL_NODE` in order to use chains from `LOCAL_CHAINS`. Signed-off-by: Luis Mastrangelo <[email protected]>
These tests rely on several chains being defined, but we only define Hedera chains. We `skip` these tests for now, but might be removed in the future. Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
acuarica
requested review from
david-bakin-sl and
Sheng-Long
and removed request for
a team
|
How can we enable coverage for these tests? |
Nana-EC
requested changes
Dec 7, 2023
Nana-EC
requested review from
svienot and
Nana-EC
and removed request for
david-bakin-sl and
Sheng-Long
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Luis Mastrangelo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Expand the API acceptance tests for the verification service. Moreover, restore the original Sourcify tests where suitable.
Related issue(s):
Fixes #
Notes for reviewer:
Checklist