Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add image version tag support #42

Merged
merged 5 commits into from
Oct 18, 2023
Merged

Add image version tag support #42

merged 5 commits into from
Oct 18, 2023

Conversation

Nana-EC
Copy link
Collaborator

@Nana-EC Nana-EC commented Oct 11, 2023 •
edited
Loading

Description:
Add image version tag support

  • Update production image tag to support version tags
  • Add integration github action to create a main image on PR pushes
  • Extend integration action to support custom tags also

Related issue(s):

Fixes #41

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@Nana-EC Nana-EC self-assigned this Oct 11, 2023
@Nana-EC Nana-EC added Improvement Code changes driven by non business requirements P1 High priority issue. Required to be completed in the assigned milestone. labels Oct 11, 2023
@Nana-EC Nana-EC added this to the 0.1.0 milestone Oct 11, 2023
@Nana-EC Nana-EC marked this pull request as ready for review October 11, 2023 23:35
quiet-node
quiet-node approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@quiet-node quiet-node left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nana-EC Nana-EC requested a review from svienot October 12, 2023 22:07
@svienot
Copy link
Contributor

svienot commented Oct 17, 2023

LGTM.
Keeping a workflow_dispatch trigger in release-integration.yml might be helpful.

@Nana-EC
Add image version tag support
4afc9e5 
Signed-off-by: Nana Essilfie-Conduah <[email protected]>
@Nana-EC
Update README with release tag details
e779cfc 
Signed-off-by: Nana Essilfie-Conduah <[email protected]>
@Nana-EC
Add support for custom latest tag
010f437 
Signed-off-by: Nana Essilfie-Conduah <[email protected]>
@Nana-EC Nana-EC force-pushed the 41-custom-image-tags branch from 5e5093b to 010f437 Compare October 18, 2023 17:51
@Nana-EC
Simplify action names
aa297f1 
Signed-off-by: Nana Essilfie-Conduah <[email protected]>
@Nana-EC
Move manual workflow dispatch to integration
54d54b5 
Signed-off-by: Nana Essilfie-Conduah <[email protected]>
@Nana-EC Nana-EC merged commit 1b7c735 into main Oct 18, 2023
2 checks passed
@Nana-EC Nana-EC deleted the 41-custom-image-tags branch October 18, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quiet-node quiet-node quiet-node approved these changes

@svienot svienot svienot approved these changes

@ericleponner ericleponner Awaiting requested review from ericleponner

Assignees

@Nana-EC Nana-EC

Labels
Improvement Code changes driven by non business requirements P1 High priority issue. Required to be completed in the assigned milestone.
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.

Support custom image tags
3 participants
@Nana-EC @svienot @quiet-node