Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update chart to support upstream images #171

Merged
merged 7 commits into from
Jun 6, 2024
Merged

feat: Update chart to support upstream images #171

merged 7 commits into from
Jun 6, 2024

Conversation

beeradb
Copy link
Contributor

@beeradb beeradb commented May 22, 2024

This PR updates the sourcify chart with changes to support using upstream images. The changes are as follows:

  • add servers.yaml, sourcify-chains.json, and local.js as Configmaps and mount them to the server container.
  • Rework container image structure in both values.yaml and the corresponding deployments.
  • Some minor linting of trailing spaces & newlines.

@beeradb beeradb requested review from a team as code owners May 22, 2024 15:23
@beeradb beeradb requested review from acuarica and Sheng-Long and removed request for a team May 22, 2024 15:23
@beeradb beeradb changed the title Update chart to support upstream images feat: Update chart to support upstream images May 23, 2024
@beeradb beeradb force-pushed the chart-updates-for-upstream-images branch from 5e41cfc to 2751cf9 Compare May 23, 2024 14:35
acuarica
acuarica requested changes May 23, 2024
View reviewed changes
Copy link
Contributor

@acuarica acuarica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks for taking care of this.

I left some improvements I didn't mention before.

charts/values.yaml Outdated Show resolved Hide resolved
charts/templates/server-repository/configmap.yaml Outdated Show resolved Hide resolved
charts/templates/server-repository/configmap.yaml Outdated Show resolved Hide resolved
charts/templates/server-repository/configmap.yaml Outdated Show resolved Hide resolved
charts/templates/server-repository/configmap.yaml Show resolved Hide resolved
acuarica
acuarica reviewed May 24, 2024
View reviewed changes
charts/values.yaml Outdated Show resolved Hide resolved
@beeradb beeradb requested a review from acuarica May 28, 2024 17:37
acuarica
acuarica previously approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@acuarica acuarica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@beeradb beeradb force-pushed the chart-updates-for-upstream-images branch from 1694e23 to 104912f Compare June 5, 2024 18:19
@beeradb beeradb requested review from a team as code owners June 5, 2024 18:19
@beeradb beeradb force-pushed the chart-updates-for-upstream-images branch from 104912f to 8aba5f4 Compare June 5, 2024 18:20
acuarica
acuarica approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@acuarica acuarica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@beeradb beeradb merged commit c070e31 into main Jun 6, 2024
8 of 9 checks passed
@beeradb beeradb deleted the chart-updates-for-upstream-images branch June 6, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromy-cannon jeromy-cannon jeromy-cannon approved these changes

@acuarica acuarica acuarica approved these changes

@Sheng-Long Sheng-Long Awaiting requested review from Sheng-Long Sheng-Long is a code owner automatically assigned from hashgraph/dev-experience

@tomzhenghedera tomzhenghedera Awaiting requested review from tomzhenghedera tomzhenghedera was automatically assigned from hashgraph/release-engineering

@rbarkerSL rbarkerSL Awaiting requested review from rbarkerSL rbarkerSL was automatically assigned from hashgraph/release-engineering-managers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@beeradb @acuarica @jeromy-cannon