Code review feedback

Signed-off-by: beeradb <[email protected]>
hashgraph · Jun 5, 2024 · 7dd9fb5 · 7dd9fb5
1 parent cae037c
commit 7dd9fb5
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 15 deletions.
diff --git a/charts/templates/server-repository/configmap.yaml b/charts/templates/server-repository/configmap.yaml
@@ -12,10 +12,6 @@ metadata:
 data:
   SERVER_URL: {{ .Values.serverRepository.config.SERVER_URL }}
   REPOSITORY_SERVER_URL: {{ .Values.serverRepository.config.REPOSITORY_SERVER_URL }}
-  SERVER_PORT: {{ .Values.serverRepository.service.server.port | quote }}
-  SERVER_EXTERNAL_PORT: {{ .Values.serverRepository.service.server.port | quote }}
-  REPOSITORY_SERVER_PORT: {{ .Values.serverRepository.service.repository.port | quote }}
-  REPOSITORY_SERVER_EXTERNAL_PORT: {{ .Values.serverRepository.service.repository.port | quote }}
   NODE_ENV: {{ .Values.serverRepository.config.NODE_ENV | default "development" }}
   SOURCIFY_SERVER: "http://{{ template "sourcify.name" . }}-server:5555"
 ---
@@ -31,8 +27,6 @@ metadata:
   {{ toYaml .Values.serverRepository.annotations | indent 4 }}
   {{- end }}
 data:
-  config.json: |-
-  {{- .Values.serverRepository.config.repository | toJson  | nindent 4 }}
   servers.yaml: |-
   {{- .Values.serverRepository.config.servers | toYaml | nindent 4 }}
   sourcify-chains.json: |-

diff --git a/charts/templates/server-repository/deployment.yaml b/charts/templates/server-repository/deployment.yaml
@@ -105,9 +105,6 @@ spec:
             - name: {{ .Chart.Name }}
               mountPath: /data
               readOnly: true
-            - name: {{ printf "%s-%s" .Chart.Name "repository" }}
-              mountPath: /redirects/config.json
-              subPath: config.json
       {{- if .Values.serverRepository.nodeSelector }}
       nodeSelector:
         {{- toYaml .Values.serverRepository.nodeSelector | nindent 8 }}

diff --git a/charts/values.yaml b/charts/values.yaml
@@ -77,12 +77,6 @@ serverRepository:
     SERVER_URL: "http://127.0.0.1:5555"
     REPOSITORY_SERVER_URL: "http://127.0.0.1:10000"
     NODE_ENV: "production"
-    repository:
-      {
-      "SERVER_URL": "http://127.0.0.1:5555",
-      "REPOSITORY_SERVER_URL": "http://127.0.0.1:10000",
-      "EXPLORER_URL": "http://127.0.0.1:8080",
-      }
     servers:
       - description: The current REST API server
         url: ""