feat: added TransactionInfo solidity example contract (#527) #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Logan Nguyen <[email protected]>
quiet-node
added
enhancement
quiet-node
requested review from
AlfredoG87,
AleksandrinaAleksieva,
ebadiere,
georgi-l95,
Ivo-Yankov,
natanasow,
yiliev0,
a team and
Nana-EC
as code owners
Test Results 18 files + 5 72 suites +10 10m 3s ⏱️ + 2m 49s For more details on these failures, see this check. Results for commit f412f24. ± Comparison against base commit 1b45c1e. ♻️ This comment has been updated with latest results. |
Signed-off-by: Logan Nguyen <[email protected]>
ebadiere
reviewed
Oct 25, 2023
|
|
||
| expect(result).to.eq(bytes32MessageCallData) | ||
| }) | ||
| }) |
There was a problem hiding this comment.
Thanks for the comment @ebadiere but that file actually already has an extra line but GitHub doesn't show the extra line. But if there is not an extra blank line at the end, it would show this symbol like this
Nana-EC
previously approved these changes
Oct 26, 2023
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
Nana-EC
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
added TransactionInfo solidity smart contract to cover below opcodes
added unit tests to cover TransactionInfo contract
Related issue(s):
Fixes #527
Notes for reviewer:
Checklist