Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added math coverage solidity example contract (#511) #521

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

quiet-node
Copy link
Member

@quiet-node quiet-node commented Oct 23, 2023

Description:

  • added MathCoverage contract to cover below opcodes

    • add(x, y)
    • sub(x, y)
    • mul(x, y)
    • div(x, y)
    • sdiv(x, y)
    • mod(x, y)
    • smod(x, y)
    • exp(x, y)
    • lt(x, y)
    • gt(x, y)
    • slt(x, y)
    • sgt(x, y)
    • eq(x, y)
    • iszero(x)
  • added unit tests to cover MathCoverage cotract

Related issue(s): #511

Fixes #511

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
iulianpascalau Iulian Pascalau
Signed-off-by: Logan Nguyen <[email protected]>
@quiet-node quiet-node added enhancement New feature or request P2 EVM evm related Tooling tooling labels Oct 23, 2023
@quiet-node quiet-node added this to the 0.6.0 milestone Oct 23, 2023
@quiet-node quiet-node self-assigned this Oct 23, 2023
@github-actions
Copy link

github-actions bot commented Oct 23, 2023

Test Results

198 tests  ±0   192 ✔️ +1   7m 57s ⏱️ +15s
  64 suites ±0       6 💤 ±0 
  14 files   ±0       0  - 1 

Results for commit 4513266. ± Comparison against base commit ab035ef.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@AlfredoG87 AlfredoG87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one Nit: blank line missing

Signed-off-by: Logan Nguyen <[email protected]>
@quiet-node quiet-node requested a review from AlfredoG87 October 25, 2023 16:35
@quiet-node quiet-node merged commit e7dd7b7 into main Oct 26, 2023
21 checks passed
@quiet-node quiet-node deleted the 511-Yul-Math-coverage branch October 26, 2023 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request EVM evm related P2 Tooling tooling
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Solidity Assembly Yul support] Math coverage
3 participants