Added tests around the voting ballot contract. #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ebadiere <[email protected]>
ebadiere
requested review from
AlfredoG87,
AleksandrinaAleksieva,
georgi-l95,
Ivo-Yankov,
natanasow,
yiliev0,
a team and
Nana-EC
as code owners
Test Results 15 files + 1 65 suites +2 8m 14s ⏱️ +28s For more details on these failures, see this check. Results for commit fac6a73. ± Comparison against base commit f19ed6d. ♻️ This comment has been updated with latest results. |
Nana-EC
requested changes
Oct 19, 2023
Signed-off-by: ebadiere <[email protected]>
Signed-off-by: ebadiere <[email protected]>
Signed-off-by: ebadiere <[email protected]>
Nana-EC
requested changes
Oct 26, 2023
TEST_SETUP.md
Outdated
| @@ -30,8 +30,12 @@ | |||
| | `OPERATOR_KEY_A` | This is the `DER Encoded Private Key` which can be found in your account portal. | | |||
| | `HEX_PRIVATE_KEY_A` | This is the `HEX Encoded Private Key` which can be found in your account portal. | | |||
| | `HEX_PRIVATE_KEY_B` | This is the `HEX Encoded Private Key` which can be found in your account portal. | | |||
| | `HEX_PRIVATE_KEY_C` | This is the `HEX Encoded Private Key` which can be found in your account portal. This key is used in the voting example. | | |||
There was a problem hiding this comment.
This isn't sustainable.
At this point this env variable should be an array.
Can you explore using a HEX_PRIVATE_KEYS that holds a list of accounts
contracts/solidity/voting/Ballot.sol
Outdated
| @@ -0,0 +1,157 @@ | |||
| // SPDX-License-Identifier: GPL-3.0 | |||
There was a problem hiding this comment.
All licenses should be Apache 2.0
Signed-off-by: ebadiere <[email protected]>
Signed-off-by: ebadiere <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the Voting example
Related issue(s):
Fixes #488