Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: added CI workflow for ERC registry tool #1168

Merged
merged 3 commits into from
Jan 14, 2025
Merged

ci: added CI workflow for ERC registry tool #1168

merged 3 commits into from
Jan 14, 2025
+62 −0

Conversation

quiet-node
Copy link
Member

@quiet-node quiet-node commented Jan 13, 2025 •
edited
Loading

Description:
This PR introduces a dedicated CI workflow for the ERC Registry tool. A new CI job, named ERC Registry Tool, will automatically run for all new PRs.

Related issue(s):

Fixes #1167

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@quiet-node quiet-node added the internal For changes that affect the project's internal workings but not its outward-facing functionality. label Jan 13, 2025
@quiet-node quiet-node added this to the 0.12.0 milestone Jan 13, 2025
@quiet-node quiet-node self-assigned this Jan 13, 2025
@quiet-node quiet-node requested review from a team as code owners January 13, 2025 22:54
@quiet-node quiet-node linked an issue Jan 13, 2025 that may be closed by this pull request
[ERC Registry] Phase 3: Add a dedicated CI workflow for ERC Registry tool #1167
Closed
@quiet-node quiet-node marked this pull request as draft January 13, 2025 22:57
@quiet-node quiet-node marked this pull request as ready for review January 13, 2025 23:05
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 13, 2025 •
edited
Loading

Test Results

 16 files  + 16   83 suites  +83   12m 16s ⏱️ + 12m 16s
294 tests +294  288 ✅ +288  6 💤 +6  0 ❌ ±0 
303 runs  +303  296 ✅ +296  7 💤 +7  0 ❌ ±0 

Results for commit 81b964b. ± Comparison against base commit 94dcdec.

♻️ This comment has been updated with latest results.

acuarica
acuarica reviewed Jan 13, 2025
View reviewed changes
Copy link
Contributor

@acuarica acuarica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I would be more explicit about this being a test (also in the PR description), as opposed to the other registry workflow which is to generate the actual registry.

.github/workflows/erc-registry-test.yml Outdated Show resolved Hide resolved
quiet-node and others added 2 commits January 13, 2025 18:28
@quiet-node
Update erc-registry-test.yml
fc92105 
Signed-off-by: Logan Nguyen <[email protected]>

Revert "Update erc-registry-test.yml"

This reverts commit e99bec8.

Reapply "Update erc-registry-test.yml"

This reverts commit f6fab40ff567c86f177c22864cde7b3dc135b27a.
@quiet-node @acuarica
fix: renamed workflow
81b964b 
Signed-off-by: Logan Nguyen <[email protected]>

Co-authored-by: Luis Mastrangelo <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
@quiet-node quiet-node force-pushed the 1167-erc-registry-phase-3-add-a-dedicated-ci-workflow-for-erc-registry-tool branch from 5b0163c to 81b964b Compare January 14, 2025 00:28
acuarica
acuarica approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@acuarica acuarica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg, although I would update the PR title and description to indicate that this is for testing.

@quiet-node quiet-node merged commit ca30825 into main Jan 14, 2025
35 checks passed
@quiet-node quiet-node deleted the 1167-erc-registry-phase-3-add-a-dedicated-ci-workflow-for-erc-registry-tool branch January 14, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbarkerSL rbarkerSL rbarkerSL approved these changes

@acuarica acuarica acuarica approved these changes

@andrewb1269hg andrewb1269hg Awaiting requested review from andrewb1269hg andrewb1269hg is a code owner automatically assigned from hashgraph/platform-ci

@leninmehedy leninmehedy Awaiting requested review from leninmehedy leninmehedy is a code owner automatically assigned from hashgraph/release-engineering-managers

@david-bakin-sl david-bakin-sl Awaiting requested review from david-bakin-sl david-bakin-sl is a code owner automatically assigned from hashgraph/hedera-smart-contracts

Assignees

@quiet-node quiet-node

Labels
internal For changes that affect the project's internal workings but not its outward-facing functionality.
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.

[ERC Registry] Phase 3: Add a dedicated CI workflow for ERC Registry tool
3 participants
@quiet-node @acuarica @rbarkerSL