Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated .github/release.yaml to include internal and github_action labeled PRs #1138

Conversation

quiet-node
Copy link
Member

Description:
This PR modified the .github/release.yaml to include internal and github_action labeled PRs

Related issue(s):

Fixes #1137

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@quiet-node quiet-node requested review from a team as code owners December 26, 2024 17:37
@quiet-node quiet-node self-assigned this Dec 26, 2024
@quiet-node quiet-node added the internal For changes that affect the project's internal workings but not its outward-facing functionality. label Dec 26, 2024
@quiet-node quiet-node added this to the 0.12.0 milestone Dec 26, 2024
Copy link

github-actions bot commented Dec 26, 2024

Test Results

 16 files  ±0   83 suites  ±0   12m 1s ⏱️ -1s
294 tests +8  288 ✅ +9  6 💤 +2  0 ❌  - 3 
303 runs  ±0  296 ✅ +1  7 💤 +2  0 ❌  - 3 

Results for commit faeaead. ± Comparison against base commit f786a64.

This pull request removes 3 and adds 11 tests. Note that renamed tests count towards both.
"before all" hook for "should be able to increase and decrease counter on V1" ‑ Proxy Upgrade Contracts Test Suite Counter Upgradable Contract Test Suite "before all" hook for "should be able to increase and decrease counter on V1"
"before all" hook for "should deposit, buy and sell tokens from ExchangeV1" ‑ Proxy Upgrade Contracts Test Suite DEX Upgradable Contract Test Suite "before all" hook for "should deposit, buy and sell tokens from ExchangeV1"
"before all" hook for "should verify it calls the correct contract and method via proxy" ‑ @OZTransparentUpgradeableProxy Test Suite "before all" hook for "should verify it calls the correct contract and method via proxy"
should be able to increase and decrease counter on V1 ‑ Proxy Upgrade Contracts Test Suite Counter Upgradable Contract Test Suite should be able to increase and decrease counter on V1
should be able to increase and decrease counter on V2 ‑ Proxy Upgrade Contracts Test Suite Counter Upgradable Contract Test Suite should be able to increase and decrease counter on V2
should be able to upgrade contract to V2 ‑ Proxy Upgrade Contracts Test Suite Counter Upgradable Contract Test Suite should be able to upgrade contract to V2
should deposit, buy and sell tokens from ExchangeV1 ‑ Proxy Upgrade Contracts Test Suite DEX Upgradable Contract Test Suite should deposit, buy and sell tokens from ExchangeV1
should deposit, buy and withdraw tokens from ExchangeV2 ‑ Proxy Upgrade Contracts Test Suite DEX Upgradable Contract Test Suite should deposit, buy and withdraw tokens from ExchangeV2
should not be able to change name ‑ Proxy Upgrade Contracts Test Suite Counter Upgradable Contract Test Suite should not be able to change name
should not be able to get version ‑ Proxy Upgrade Contracts Test Suite DEX Upgradable Contract Test Suite should not be able to get version
should upgrade contract to V2 ‑ Proxy Upgrade Contracts Test Suite DEX Upgradable Contract Test Suite should upgrade contract to V2
should verify it calls the correct contract and method via proxy ‑ @OZTransparentUpgradeableProxy Test Suite should verify it calls the correct contract and method via proxy
should verify it can change the underlying contract ‑ @OZTransparentUpgradeableProxy Test Suite should verify it can change the underlying contract
…

♻️ This comment has been updated with latest results.

Copy link
Contributor

@acuarica acuarica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Logan for taking care of this, left some questions we can discuss.

.github/release.yml Show resolved Hide resolved
.github/release.yml Show resolved Hide resolved
Copy link
Contributor

@acuarica acuarica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg

@quiet-node quiet-node merged commit 69dfbd7 into main Jan 7, 2025
31 checks passed
@quiet-node quiet-node deleted the 1137-update-releaseyml-to-include-internal-and-github_action-labeled-prs branch January 7, 2025 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal For changes that affect the project's internal workings but not its outward-facing functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update release.yml to include internal and github_action labeled PRs
3 participants