-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use Stake
value at the end of the day as weight in StakingNodeInfo
#17285
Conversation
Signed-off-by: Neeharika-Sompalli <[email protected]>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17285 +/- ##
============================================
- Coverage 67.41% 67.41% -0.01%
- Complexity 22064 22094 +30
============================================
Files 2585 2588 +3
Lines 96408 96613 +205
Branches 10071 10092 +21
============================================
+ Hits 64993 65130 +137
- Misses 27698 27756 +58
- Partials 3717 3727 +10
|
… is true Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
.../java/com/hedera/node/app/service/token/impl/handlers/staking/EndOfStakingPeriodUpdater.java
Show resolved
Hide resolved
Signed-off-by: Neeharika-Sompalli <[email protected]>
…2-weight-to-stake
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tyvm @Neeharika-Sompalli !
Fixes #17252
All the code changes are behind
addressBook.useRosterLifecycle
feature flag.When
addressBook.useRosterLifecycle=true
,addressBook.useRosterLifecycle
feature flag is on.StakingNodeInfo
andNode
objects.stake
fromStakingNodeInfo
to set as weight inRoster
whenPREPARE_UPGRADE
is handled.