Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: HIP-756 Get Schedule Token Create Info queries implementation #17263

Merged
merged 6 commits into from
Jan 10, 2025

Conversation

stoyanov-st
Copy link
Contributor

Description:

This PR aims to expose the query function calls for receiving the TokenInfo for Scheduled Token Create.
Each function is corresponding to the scheduled token type.

Related issue(s):

Fixes #16963

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@stoyanov-st stoyanov-st added this to the v0.59 milestone Jan 8, 2025
@stoyanov-st stoyanov-st self-assigned this Jan 8, 2025
@stoyanov-st stoyanov-st requested review from a team and tinker-michaelj as code owners January 8, 2025 08:04
Copy link

codacy-production bot commented Jan 8, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 71.81%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (be1981d) 96191 68558 71.27%
Head commit (6da2d0e) 96378 (+187) 68692 (+134) 71.27% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17263) 188 135 71.81%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 67.55319% with 61 lines in your changes missing coverage. Please review.

Project coverage is 67.41%. Comparing base (be1981d) to head (6da2d0e).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...impl/exec/systemcontracts/hts/TokenTupleUtils.java 50.45% 49 Missing and 5 partials ⚠️
...p/service/contract/impl/utils/ConversionUtils.java 37.50% 4 Missing and 1 partial ⚠️
...duledinfo/GetScheduledFungibleTokenCreateCall.java 95.65% 0 Missing and 1 partial ⚠️
...edinfo/GetScheduledNonFungibleTokenCreateCall.java 95.65% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##               main   #17263    +/-   ##
==========================================
  Coverage     67.41%   67.41%            
- Complexity    22063    22092    +29     
==========================================
  Files          2585     2588     +3     
  Lines         96408    96595   +187     
  Branches      10071    10087    +16     
==========================================
+ Hits          64992    65119   +127     
- Misses        27698    27751    +53     
- Partials       3718     3725     +7     
Files with missing lines Coverage Δ
...p/service/contract/impl/exec/gas/DispatchType.java 100.00% <100.00%> (ø)
...act/impl/exec/processors/HssTranslatorsModule.java 100.00% <100.00%> (ø)
...s/getscheduledinfo/GetScheduledInfoTranslator.java 100.00% <100.00%> (ø)
...duledinfo/GetScheduledFungibleTokenCreateCall.java 95.65% <95.65%> (ø)
...edinfo/GetScheduledNonFungibleTokenCreateCall.java 95.65% <95.65%> (ø)
...p/service/contract/impl/utils/ConversionUtils.java 86.75% <37.50%> (-1.87%) ⬇️
...impl/exec/systemcontracts/hts/TokenTupleUtils.java 76.17% <50.45%> (-19.07%) ⬇️

... and 1 file with indirect coverage changes

Impacted file tree graph

lukelee-sl
lukelee-sl previously approved these changes Jan 9, 2025
Copy link
Member

@lukelee-sl lukelee-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. very clean. just a couple of nits

Signed-off-by: Stanimir Stoyanov <[email protected]>
Copy link
Member

@lukelee-sl lukelee-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukelee-sl lukelee-sl merged commit 50747ad into main Jan 10, 2025
48 of 49 checks passed
@lukelee-sl lukelee-sl deleted the 16963-schedule-get-info-queries branch January 10, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[HIP-756] Add implementations for ScheduleGetInfo queries to the HSS System Contract
2 participants