-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: HIP-756 Get Schedule Token Create Info queries implementation #17263
Conversation
Signed-off-by: Stanimir Stoyanov <[email protected]>
Signed-off-by: Stanimir Stoyanov <[email protected]>
Signed-off-by: Stanimir Stoyanov <[email protected]>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17263 +/- ##
==========================================
Coverage 67.41% 67.41%
- Complexity 22063 22092 +29
==========================================
Files 2585 2588 +3
Lines 96408 96595 +187
Branches 10071 10087 +16
==========================================
+ Hits 64992 65119 +127
- Misses 27698 27751 +53
- Partials 3718 3725 +7
|
...java/com/hedera/node/app/service/contract/impl/exec/systemcontracts/hts/TokenTupleUtils.java
Show resolved
Hide resolved
...t/impl/exec/systemcontracts/hss/getscheduledinfo/GetScheduledNonFungibleTokenCreateCall.java
Outdated
Show resolved
Hide resolved
...t/impl/exec/systemcontracts/hss/getscheduledinfo/GetScheduledNonFungibleTokenCreateCall.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. very clean. just a couple of nits
Signed-off-by: Stanimir Stoyanov <[email protected]>
Signed-off-by: Stanimir Stoyanov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description:
This PR aims to expose the query function calls for receiving the TokenInfo for Scheduled Token Create.
Each function is corresponding to the scheduled token type.
Related issue(s):
Fixes #16963
Notes for reviewer:
Checklist