Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remaining renaming to Hiero #2150

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

0xivanov
Copy link
Contributor

@0xivanov 0xivanov commented Dec 20, 2024

Description:

  • Rename packages in /examples and in /example-android
  • Rename imports in /examples and in /example-android
  • Rename usages in .md files and kotlin files

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@0xivanov 0xivanov self-assigned this Dec 20, 2024
@0xivanov 0xivanov requested review from a team as code owners December 20, 2024 10:34
Copy link
Member

@hendrikebbers hendrikebbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we split this PR?

@@ -129,4 +129,4 @@ jobs:
env:
NEXUS_USERNAME: ${{ secrets.SONATYPE_USERNAME }}
NEXUS_PASSWORD: ${{ secrets.SONATYPE_PASSWORD }}
run: ./gradlew releaseMavenCentral -PpublishingPackageGroup=org.hiero -PpublishSigningEnabled=true --scan --no-configuration-cache
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be done bore the SDK is transfered to Hiero


![](https://img.shields.io/badge/java-17%2B-blue?style=flat-square)
![](https://img.shields.io/badge/android-26%2B-blue?style=flat-square)
[![](https://img.shields.io/github/actions/workflow/status/hashgraph/hedera-sdk-java/build.yml?style=flat-square)](https://github.com/hashgraph/hedera-sdk-java/actions)
[![](https://img.shields.io/maven-central/v/com.hedera.hashgraph/sdk/2?label=maven&style=flat-square)](https://search.maven.org/artifact/com.hedera.hashgraph/sdk)

> The Java SDK for interacting with Hedera Hashgraph: the official distributed
> The Java SDK for interacting with Hiero: the official distributed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> The Java SDK for interacting with Hiero: the official distributed
> The Java SDK for interacting with a Hiero based network: the official distributed

The [developer quickstart guide](docs/sdk/developer-guide.md) provides instructions on how to set up the environment,
run unit and integration tests, and configure the project to work with different networks
such as the Hedera test network, preview network, etc.
such as the Hiero test network, preview network, etc.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to be reverted

@@ -1,5 +1,5 @@
// SPDX-License-Identifier: Apache-2.0
package com.hedera.android_example.ui.main
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should do this in multiple steps. This PR is too big to not oversee any issue ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants