-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: rename packages to hiero #2141
Conversation
Signed-off-by: Ivan Ivanov <[email protected]>
Hey @jjohannes , do you think it's possible to rename the packages to without breaking the |
Renaming a package is technically changing the API. To be consistent, we need to rename everything at once in my opinion:
Users that switch to the new Hiero version of the SDK will have to adjust there imports to the new package(s). But the classes themselves will work as before. Only the imports need to be adjusted. |
Signed-off-by: Ivan Ivanov <[email protected]>
Signed-off-by: Ivan Ivanov <[email protected]>
Signed-off-by: Ivan Ivanov <[email protected]>
Signed-off-by: Ivan Ivanov <[email protected]>
Signed-off-by: Ivan Ivanov <[email protected]>
Signed-off-by: Ivan Ivanov <[email protected]>
@jjohannes I don't know why the examples are not building, i haven't touched them. Do you have any ideas? |
With the rename, the examples now automatically use the last published version of the That version is without the recent Guava/CheckerQual version update. But the build setup used for the example expects a newer version due to our strict Java Module setup. The newer version has a You can update the Guava version in the example directly – dependency constraints block – to make it work with the previous version:
|
Signed-off-by: Ivan Ivanov <[email protected]>
Signed-off-by: Ivan Ivanov <[email protected]>
Signed-off-by: Ivan Ivanov <[email protected]>
Signed-off-by: Ivan Ivanov <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2141 +/- ##
============================================
+ Coverage 82.20% 82.41% +0.20%
- Complexity 3588 4042 +454
============================================
Files 186 205 +19
Lines 11697 12911 +1214
Branches 1150 1283 +133
============================================
+ Hits 9615 10640 +1025
- Misses 1604 1813 +209
+ Partials 478 458 -20 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Ivan Ivanov <[email protected]>
…ph/hedera-sdk-java into rename-packages-to-hiero
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review applies to:
.github/workflows/build.yml
.github/workflows/release-artifacts.yml
Signed-off-by: Ivan Ivanov <[email protected]>
Signed-off-by: Ivan Ivanov <[email protected]>
The package for the protobuf-generated classes should probably also be changed: See: https://github.com/hashgraph/hedera-sdk-java/blob/main/sdk/src/main/proto/account.proto#L28-L29 The content of |
Signed-off-by: Ivan Ivanov <[email protected]>
@jjohannes Nice observation! Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approval applies to:
- .github/workflows/release-artifacts.yml
- example-android/app/build.gradle.kts
- example-android/build.gradle.kts
- example-android/settings.gradle.kts
- examples/build.gradle.kts
- settings.gradle.kts
- tck/build.gradle.kts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work, tyvm @0xivanov @jjohannes
Description:
Related issue(s): #2017
Fixes #
Notes for reviewer:
Checklist