Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIP-423: Long Term Scheduled Transactions #2123

Merged
merged 7 commits into from
Dec 11, 2024

Conversation

0xivanov
Copy link
Contributor

@0xivanov 0xivanov commented Dec 5, 2024

Description:
This PR implements Integration tests for HIP-423 and updates protobufs to v0.57

Related issue(s):

Fixes #2105

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Ivan Ivanov <[email protected]>
Signed-off-by: Ivan Ivanov <[email protected]>
Signed-off-by: Ivan Ivanov <[email protected]>
@0xivanov 0xivanov self-assigned this Dec 5, 2024
@0xivanov 0xivanov requested review from a team as code owners December 5, 2024 11:47
@0xivanov 0xivanov changed the title HIP-432: Long Term Acheduled Transactions HIP-432: Long Term Scheduled Transactions Dec 5, 2024
mishomihov00
mishomihov00 previously approved these changes Dec 5, 2024
Copy link
Contributor

@mishomihov00 mishomihov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review applies to:
.github/workflows/build.yml

jeromy-cannon
jeromy-cannon previously approved these changes Dec 5, 2024
Signed-off-by: Ivan Ivanov <[email protected]>
@0xivanov 0xivanov dismissed stale reviews from jeromy-cannon and mishomihov00 via f405c54 December 9, 2024 10:44
Signed-off-by: Ivan Ivanov <[email protected]>
sdk/src/main/java/com/hedera/hashgraph/sdk/Status.java Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.12%. Comparing base (b86ee46) to head (5b77eac).
Report is 189 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2123      +/-   ##
============================================
+ Coverage     82.20%   83.12%   +0.92%     
- Complexity     3588     3987     +399     
============================================
  Files           186      199      +13     
  Lines         11697    12726    +1029     
  Branches       1150     1256     +106     
============================================
+ Hits           9615    10578     +963     
- Misses         1604     1693      +89     
+ Partials        478      455      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@PavelSBorisov PavelSBorisov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review applies for:
.github/workflows/build.yml

@0xivanov 0xivanov changed the title HIP-432: Long Term Scheduled Transactions HIP-423: Long Term Scheduled Transactions Dec 11, 2024
@0xivanov 0xivanov merged commit 472693d into main Dec 11, 2024
9 checks passed
@0xivanov 0xivanov deleted the 2105-hip-432-Long-Term-Scheduled-Transactions branch December 11, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add HIP-423: Long Term Scheduled Transactions
6 participants