revert: query the consensus nodes for the account balance, account info, and contract info data #1840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce, account info, and contract info data (#1698)" (leave some useful chores which not really related to the feat) This reverts commit 8243cf6 Signed-off-by: Nikita Lebedev <[email protected]>
…ountEvmAddressAsync methods in AccountId and populateContractNumAsync in ContractId (#1829)" Signed-off-by: Nikita Lebedev <[email protected]>
This was referenced Jun 10, 2024
|
Better to keep it but make it a feature flag that's off by default. |
|
thenswan
changed the title
thenswan
changed the title
thenswan
changed the title
thenswan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR reverts #1698 (also #1825 and part of #1829) to address:
hedera-services(because of the decision regarding HIP-367).Related issue(s):
Closes #1838 #1839
Notes for reviewer:
Decided to leave couple useful chores in:
IntegrationTestEnv(variable names)ClientHelper(variable names)ClientTest(test fix)