Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge develop into main #1686

Merged
merged 10 commits into from
Dec 20, 2023
Merged

Merge develop into main #1686

merged 10 commits into from
Dec 20, 2023

Conversation

rokn
Copy link

@rokn rokn commented Dec 19, 2023

Description:

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (cf1c1e3) 82.21% compared to head (b86ee46) 82.20%.
Report is 5 commits behind head on main.

Files Patch % Lines
.../main/java/com/hedera/hashgraph/sdk/PublicKey.java 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1686      +/-   ##
============================================
- Coverage     82.21%   82.20%   -0.02%     
  Complexity     3588     3588              
============================================
  Files           186      186              
  Lines         11697    11697              
  Branches       1148     1150       +2     
============================================
- Hits           9617     9615       -2     
- Misses         1603     1604       +1     
- Partials        477      478       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rokn rokn closed this Dec 19, 2023
@rokn rokn reopened this Dec 19, 2023
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

75.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@rokn rokn merged commit 04f55bf into main Dec 20, 2023
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants