Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent spurious INVALID_TRANSACTION_START #1660

Merged
merged 3 commits into from
Dec 7, 2023

Conversation

thenswan
Copy link
Contributor

@thenswan thenswan commented Dec 6, 2023

Description:
Prevent spurious INVALID_TRANSACTION_START by subtracting fixed NANOSECONDS_TO_REMOVE from currentTime in TransactionId.generate().

Related issue(s):
Fixes #1652

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@thenswan thenswan requested a review from rokn December 6, 2023 11:26
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7ffc434) 82.26% compared to head (4e62a5e) 82.21%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1660      +/-   ##
=============================================
- Coverage      82.26%   82.21%   -0.06%     
+ Complexity      3590     3589       -1     
=============================================
  Files            186      186              
  Lines          11692    11697       +5     
  Branches        1148     1150       +2     
=============================================
- Hits            9619     9617       -2     
- Misses          1598     1603       +5     
- Partials         475      477       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Nikita Lebedev <[email protected]>
Signed-off-by: Nikita Lebedev <[email protected]>
@thenswan thenswan marked this pull request as ready for review December 7, 2023 10:48
@thenswan thenswan requested a review from SimiHunjan as a code owner December 7, 2023 10:48
Copy link

sonarqubecloud bot commented Dec 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@thenswan thenswan merged commit b7e6229 into develop Dec 7, 2023
7 of 8 checks passed
@thenswan thenswan deleted the 1652-prevent-spurious-INVALID_TRANSACTION_START branch December 7, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v2.29's transaction valid start no longer caters for time drift between client and node
2 participants