Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIP-631 - add SDK support for virtual addresses #1315

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

nikola-genov
Copy link

Signed-off-by: Nikola Genov [email protected]

Description:

This PR adds java SDK support for virtual EVM addresses to a Hedera Account

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Nikola Genov added 3 commits January 31, 2023 11:32
Signed-off-by: Nikola Genov <[email protected]>
Signed-off-by: Nikola Genov <[email protected]>
Signed-off-by: Nikola Genov <[email protected]>
@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Base: 74.40% // Head: 73.87% // Decreases project coverage by -0.54% ⚠️

Coverage data is based on head (467aead) compared to base (1f10df5).
Patch coverage: 27.46% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1315      +/-   ##
=============================================
- Coverage      74.40%   73.87%   -0.54%     
- Complexity      2875     2880       +5     
=============================================
  Files            184      187       +3     
  Lines          11391    11505     +114     
  Branches        1121     1128       +7     
=============================================
+ Hits            8476     8499      +23     
- Misses          2255     2343      +88     
- Partials         660      663       +3     
Impacted Files Coverage Δ
...n/java/com/hedera/hashgraph/sdk/ContractNonce.java 0.00% <0.00%> (ø)
.../main/java/com/hedera/hashgraph/sdk/PublicKey.java 65.85% <ø> (ø)
...ava/com/hedera/hashgraph/sdk/PublicKeyED25519.java 78.12% <0.00%> (-2.53%) ⬇️
.../com/hedera/hashgraph/sdk/TransferTransaction.java 65.40% <0.00%> (-0.56%) ⬇️
.../java/com/hedera/hashgraph/sdk/VirtualAddress.java 0.00% <0.00%> (ø)
...a/com/hedera/hashgraph/sdk/VirtualAddressInfo.java 0.00% <0.00%> (ø)
...m/hedera/hashgraph/sdk/ContractFunctionResult.java 78.94% <40.00%> (-2.17%) ⬇️
...hedera/hashgraph/sdk/AccountCreateTransaction.java 75.19% <44.44%> (-2.41%) ⬇️
.../main/java/com/hedera/hashgraph/sdk/AccountId.java 73.83% <45.45%> (-0.43%) ⬇️
...main/java/com/hedera/hashgraph/sdk/EvmAddress.java 63.15% <50.00%> (-3.51%) ⬇️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 7, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 10 Code Smells

36.0% 36.0% Coverage
0.0% 0.0% Duplication

@SimiHunjan
Copy link
Contributor

Noting this PR should not be merged until we have reached final design decisions for this HIP and approved the API design in the design review meetings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants