Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/metadata-key #62

Merged
merged 11 commits into from
Jun 5, 2024
Merged

feat/metadata-key #62

merged 11 commits into from
Jun 5, 2024

Conversation

michalrozekariane
Copy link
Contributor

Description:

This pull request introduces several updates to the NFT SDK, focusing on improving the collection creation functionality and ensuring compliance with recent @hashgraph/sdk changes. Here are the key changes included:

  • Addition of metadataKey property for create-collection function,
  • Updated tests for new metadataKey integration,
  • Fixed tests for autoRenewPeriod functionality,
  • Documentation updates

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

…and new case for autoRenewPeriod created

Signed-off-by: michalrozekariane <[email protected]>
Signed-off-by: michalrozekariane <[email protected]>
Copy link

github-actions bot commented May 6, 2024

Jest Node 20 Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
1 files    0
1 errors

Results for commit a7bba75.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 6, 2024

Jest Node 18 Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
1 files    0
1 errors

Results for commit a7bba75.

♻️ This comment has been updated with latest results.

Signed-off-by: michalrozekariane <[email protected]>
@michalrozekariane michalrozekariane marked this pull request as draft May 7, 2024 07:17
Signed-off-by: kacper-koza-arianelabs <[email protected]>
@kacper-koza-arianelabs kacper-koza-arianelabs marked this pull request as ready for review June 4, 2024 13:28
michalrozekariane and others added 2 commits June 4, 2024 16:50
Signed-off-by: michalrozekariane <[email protected]>
Signed-off-by: kacper-koza-arianelabs <[email protected]>
Co-authored-by: kacper-koza-arianelabs <[email protected]>
Signed-off-by: kacper-koza-arianelabs <[email protected]>
@jeromy-cannon jeromy-cannon merged commit 6732204 into main Jun 5, 2024
2 checks passed
@jeromy-cannon jeromy-cannon deleted the feat/metadata-key branch June 5, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants