Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add LZ <> Hedera HTS Connector for existing token example #3361

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

natanasow
Copy link
Collaborator

@natanasow natanasow commented Jan 8, 2025

Description:

Add an HTS Connector on Hedera <-> OFT Adapter on other EVM chain i.e. use HTS to represent a popular ERC 20 on Hedera.

Also resolving these comments:

Related issue(s):

Fixes #3339

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@natanasow natanasow self-assigned this Jan 8, 2025
Copy link

github-actions bot commented Jan 8, 2025

Test Results

 21 files  +  4  264 suites  +36   58m 24s ⏱️ + 26m 38s
613 tests +  9  603 ✅ +  3  4 💤 ±0  6 ❌ +6 
733 runs  +113  723 ✅ +107  4 💤 ±0  6 ❌ +6 

For more details on these failures, see this check.

Results for commit a4c5e58. ± Comparison against base commit 68fce9a.

♻️ This comment has been updated with latest results.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
26.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@natanasow natanasow added the enhancement New feature or request label Jan 10, 2025
@natanasow natanasow modified the milestones: 0.65.0, 0.64.0 Jan 10, 2025
@natanasow natanasow marked this pull request as ready for review January 10, 2025 14:39
@natanasow natanasow requested review from georgi-l95, Ivo-Yankov and a team as code owners January 10, 2025 14:39
@natanasow natanasow requested a review from lukelee-sl January 10, 2025 14:39
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.98%. Comparing base (68fce9a) to head (a4c5e58).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3361      +/-   ##
==========================================
- Coverage   85.02%   84.98%   -0.05%     
==========================================
  Files          69       69              
  Lines        4688     4721      +33     
  Branches     1050     1063      +13     
==========================================
+ Hits         3986     4012      +26     
- Misses        392      394       +2     
- Partials      310      315       +5     
Flag Coverage Δ
config-service 98.14% <ø> (ø)
relay 79.50% <ø> (-0.23%) ⬇️
server 83.28% <ø> (ø)
ws-server 36.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG
I think we've collected a lot of good findings now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LZ <-> Hedera examples
2 participants