Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Grafana Initial Dashboard and Dev Env for Metrics #97

Merged
merged 3 commits into from
Aug 13, 2024

Conversation

AlfredoG87
Copy link
Contributor

@AlfredoG87 AlfredoG87 commented Aug 12, 2024

Description:
Added initial metrics dashboard and dev containers to the dev docker-compose stack, so it includes a preconfigured Grafana + Prometheus services, with provisioned dashboard on source.

Added documentation for metrics as well.

Related issue(s):

Fixes #96
Fixes #94
Fixes #85
Fixes #93

Notes for reviewer:
imageChecklist
image

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

…compose stack, so it includes a preconfigured Grafana + Prometheus services, with provisioned dashboard on source.

Added documentation for metrics as well.

Signed-off-by: Alfredo Gutierrez <[email protected]>
@AlfredoG87 AlfredoG87 self-assigned this Aug 12, 2024
@AlfredoG87 AlfredoG87 added Improvement Code changes driven by non business requirements P2 Required to be completed in the assigned milestone, but may or may not impact release schedule. labels Aug 12, 2024
@AlfredoG87 AlfredoG87 added this to the 0.1.0 milestone Aug 12, 2024
@AlfredoG87 AlfredoG87 marked this pull request as ready for review August 12, 2024 21:25
@AlfredoG87 AlfredoG87 requested a review from a team as a code owner August 12, 2024 21:25
Signed-off-by: Alfredo Gutierrez <[email protected]>
Copy link
Contributor

@mattp-swirldslabs mattp-swirldslabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of little doc changes. Nice work!

server/docs/metrics.md Show resolved Hide resolved
server/docs/metrics.md Outdated Show resolved Hide resolved
Signed-off-by: Alfredo Gutierrez <[email protected]>
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (0ca1c5e) to head (f23a057).

Additional details and impacted files
@@             Coverage Diff             @@
##                main       #97   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       110       110           
===========================================
  Files             19        19           
  Lines            420       414    -6     
  Branches          23        23           
===========================================
- Hits             420       414    -6     
Files Coverage Δ
...a/block/server/config/BlockNodeContextFactory.java 100.00% <100.00%> (ø)
...om/hedera/block/server/metrics/MetricsService.java 100.00% <ø> (ø)

@AlfredoG87 AlfredoG87 merged commit c6fb100 into main Aug 13, 2024
8 checks passed
@AlfredoG87 AlfredoG87 deleted the grafana-dev-dashboard branch August 13, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Code changes driven by non business requirements P2 Required to be completed in the assigned milestone, but may or may not impact release schedule.
Projects
None yet
2 participants