Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgraded gradlew to 8.8 to match services and fix 00081 #83

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

mattp-swirldslabs
Copy link
Contributor

@mattp-swirldslabs mattp-swirldslabs commented Aug 5, 2024

Description:
./gradlew tasks command was failing because one of the plugins was relying on a MapProperty function in a later version of gradle (at least 8.8)

  • I upgraded gradlew from 8.5 to 8.8 and this fixed the issue

Related issue(s):

Fixes #81

@mattp-swirldslabs mattp-swirldslabs self-assigned this Aug 5, 2024
@mattp-swirldslabs mattp-swirldslabs added this to the 0.1.0 milestone Aug 5, 2024
@mattp-swirldslabs mattp-swirldslabs force-pushed the 00081-gradlew-tasks-bug branch from 4aecb81 to 7f4176e Compare August 5, 2024 20:05
@mattp-swirldslabs mattp-swirldslabs added the Bug A error that causes the feature to behave differently than what was expected based on design docs label Aug 5, 2024
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.33%. Comparing base (6ddb2fb) to head (7f4176e).

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #83       +/-   ##
===========================================
+ Coverage        0   54.33%   +54.33%     
- Complexity      0       25       +25     
===========================================
  Files           0        7        +7     
  Lines           0      173      +173     
  Branches        0        6        +6     
===========================================
+ Hits            0       94       +94     
- Misses          0       75       +75     
- Partials        0        4        +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattp-swirldslabs mattp-swirldslabs marked this pull request as ready for review August 5, 2024 20:11
@mattp-swirldslabs mattp-swirldslabs requested a review from a team as a code owner August 5, 2024 20:11
Copy link
Contributor

@AlfredoG87 AlfredoG87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice finding!

@mattp-swirldslabs mattp-swirldslabs merged commit e08b91a into main Aug 5, 2024
10 of 11 checks passed
@mattp-swirldslabs mattp-swirldslabs deleted the 00081-gradlew-tasks-bug branch August 5, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A error that causes the feature to behave differently than what was expected based on design docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gradlew tasks command throws errors
2 participants