-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: test check - and pr checks consolidation into single workflow #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlfredoG87
changed the title
Ci test check - and pr-checks consolidation into single workflow
ci: test check - and pr-checks consolidation into single workflow
Jul 23, 2024
AlfredoG87
added
Improvement
Code changes driven by non business requirements
P2
Required to be completed in the assigned milestone, but may or may not impact release schedule.
Release
Issues tied to release management functions
labels
Jul 23, 2024
AlfredoG87
changed the title
ci: test check - and pr-checks consolidation into single workflow
ci: test check - and pr checks consolidation into single workflow
Jul 23, 2024
AlfredoG87
changed the title
ci: test check - and pr checks consolidation into single workflow
ci2: test check - and pr checks consolidation into single workflow
Jul 23, 2024
AlfredoG87
changed the title
ci2: test check - and pr checks consolidation into single workflow
ci: test check - and pr checks consolidation into single workflow
Jul 23, 2024
rbarkerSL
requested changes
Jul 29, 2024
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
rbarkerSL
previously approved these changes
Jul 29, 2024
AlfredoG87
force-pushed
the
ci-test-check
branch
from
July 29, 2024 18:12
9efbe8c
to
1e3e30b
Compare
…s check) and adds Unit Test check and Code Coverage upload. Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
…bel(s) Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
…ase speed and efficiency but also keeping it clear what steps are failing and what is passing Signed-off-by: Alfredo Gutierrez <[email protected]>
…ase speed and efficiency but also keeping it clear what steps are failing and what is passing Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
AlfredoG87
force-pushed
the
ci-test-check
branch
from
July 29, 2024 18:13
1e3e30b
to
292ca58
Compare
rbarkerSL
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Improvement
Code changes driven by non business requirements
P2
Required to be completed in the assigned milestone, but may or may not impact release schedule.
Release
Issues tied to release management functions
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Consolidates 2 current workflows: "build" and "spotless check" into a single one, and also adds unit test check and code coverage report upload.
All other checks that depend on gradle tasks should be done in this WF, this way is more efficient, since we avoid code duplication and run duplication since on each workflow we used to do perform the same baseline tasks such as checkout and build.
Related issue(s):
Fixes #49
Fixes #50
Notes for reviewer:
When at least one step fails:
When all steps pass:
Checklist