Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: test check - and pr checks consolidation into single workflow #51

Merged
merged 15 commits into from
Jul 29, 2024

Conversation

AlfredoG87
Copy link
Contributor

@AlfredoG87 AlfredoG87 commented Jul 22, 2024

Description:
Consolidates 2 current workflows: "build" and "spotless check" into a single one, and also adds unit test check and code coverage report upload.

All other checks that depend on gradle tasks should be done in this WF, this way is more efficient, since we avoid code duplication and run duplication since on each workflow we used to do perform the same baseline tasks such as checkout and build.

Related issue(s):

Fixes #49
Fixes #50

Notes for reviewer:
When at least one step fails:
image
When all steps pass:
image

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@AlfredoG87 AlfredoG87 requested review from a team as code owners July 22, 2024 21:41
@AlfredoG87 AlfredoG87 marked this pull request as draft July 22, 2024 21:55
@AlfredoG87 AlfredoG87 closed this Jul 22, 2024
@AlfredoG87 AlfredoG87 reopened this Jul 22, 2024
@AlfredoG87 AlfredoG87 changed the title Ci test check - and pr-checks consolidation into single workflow ci: test check - and pr-checks consolidation into single workflow Jul 23, 2024
@AlfredoG87 AlfredoG87 self-assigned this Jul 23, 2024
@AlfredoG87 AlfredoG87 added Improvement Code changes driven by non business requirements P2 Required to be completed in the assigned milestone, but may or may not impact release schedule. Release Issues tied to release management functions labels Jul 23, 2024
@AlfredoG87 AlfredoG87 added this to the 0.1.0 milestone Jul 23, 2024
@AlfredoG87 AlfredoG87 changed the title ci: test check - and pr-checks consolidation into single workflow ci: test check - and pr checks consolidation into single workflow Jul 23, 2024
@AlfredoG87 AlfredoG87 changed the title ci: test check - and pr checks consolidation into single workflow ci2: test check - and pr checks consolidation into single workflow Jul 23, 2024
@AlfredoG87 AlfredoG87 changed the title ci2: test check - and pr checks consolidation into single workflow ci: test check - and pr checks consolidation into single workflow Jul 23, 2024
@AlfredoG87 AlfredoG87 marked this pull request as ready for review July 24, 2024 00:03
Copy link

codecov bot commented Jul 29, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

rbarkerSL
rbarkerSL previously approved these changes Jul 29, 2024
…s check) and adds Unit Test check and Code Coverage upload.

Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
…ase speed and efficiency but also keeping it clear what steps are failing and what is passing

Signed-off-by: Alfredo Gutierrez <[email protected]>
…ase speed and efficiency but also keeping it clear what steps are failing and what is passing

Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
@AlfredoG87 AlfredoG87 merged commit b5bebc5 into main Jul 29, 2024
4 checks passed
@AlfredoG87 AlfredoG87 deleted the ci-test-check branch July 29, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Code changes driven by non business requirements P2 Required to be completed in the assigned milestone, but may or may not impact release schedule. Release Issues tied to release management functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code Coverage Report Upload GHA WF for Unit Test Pass Verification on PR
2 participants