Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Switch license declarations to SPDX #447

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Conversation

jsync-swirlds
Copy link
Member

Change all license declarations to SPDX format and change spotless configuration to require the same.

@jsync-swirlds jsync-swirlds self-assigned this Jan 6, 2025
@jsync-swirlds jsync-swirlds added this to the 0.4.0 milestone Jan 6, 2025
@jsync-swirlds jsync-swirlds added the Block Node Issues/PR related to the Block Node. label Jan 6, 2025
@jsync-swirlds jsync-swirlds marked this pull request as ready for review January 6, 2025 19:47
@jsync-swirlds jsync-swirlds requested review from a team as code owners January 6, 2025 19:47
Copy link
Contributor

@andrewb1269hg andrewb1269hg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve the Devops-CI assigned files.

Copy link
Contributor

@AlfredoG87 AlfredoG87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mattp-swirldslabs mattp-swirldslabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Contributor

@ata-nas ata-nas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! As a side effect, we have also had the chance to run spotless on all files now with palantir, which is nice, some code was formatted to match that.

@jsync-swirlds jsync-swirlds merged commit c303fa0 into main Jan 7, 2025
25 of 27 checks passed
@jsync-swirlds jsync-swirlds deleted the switch-to-SPDX branch January 7, 2025 14:44
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.78%. Comparing base (287adeb) to head (9089a76).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #447   +/-   ##
=========================================
  Coverage     96.77%   96.78%           
  Complexity      409      409           
=========================================
  Files            82       82           
  Lines          1458     1460    +2     
  Branches         90       90           
=========================================
+ Hits           1411     1413    +2     
  Misses           34       34           
  Partials         13       13           
Files with missing lines Coverage Δ
...java/com/hedera/block/common/utils/ChunkUtils.java 100.00% <ø> (ø)
...a/com/hedera/block/common/utils/FileUtilities.java 100.00% <ø> (ø)
...a/com/hedera/block/common/utils/MathUtilities.java 100.00% <ø> (ø)
...a/com/hedera/block/common/utils/Preconditions.java 100.00% <ø> (ø)
...com/hedera/block/common/utils/StringUtilities.java 100.00% <ø> (ø)
...ain/java/com/hedera/block/server/BlockNodeApp.java 100.00% <ø> (ø)
...dera/block/server/BlockNodeAppInjectionModule.java 100.00% <ø> (ø)
...ain/java/com/hedera/block/server/ServerConfig.java 100.00% <ø> (ø)
.../block/server/config/BlockNodeConfigExtension.java 100.00% <ø> (ø)
...m/hedera/block/server/config/BlockNodeContext.java 100.00% <100.00%> (ø)
... and 72 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Block Node Issues/PR related to the Block Node.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants