-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Switch license declarations to SPDX #447
Conversation
Signed-off-by: Joseph Sinclair <[email protected]>
Signed-off-by: Joseph Sinclair <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve the Devops-CI assigned files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! As a side effect, we have also had the chance to run spotless on all files now with palantir, which is nice, some code was formatted to match that.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #447 +/- ##
=========================================
Coverage 96.77% 96.78%
Complexity 409 409
=========================================
Files 82 82
Lines 1458 1460 +2
Branches 90 90
=========================================
+ Hits 1411 1413 +2
Misses 34 34
Partials 13 13
|
Change all license declarations to SPDX format and change spotless configuration to require the same.