-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI Test Check for Style guidelines using Spotless plugin #43
Conversation
…ct style guidelines. I will also show how to fix things running ./gradlew spotlessApply Signed-off-by: Alfredo Gutierrez <[email protected]>
It might be worth taking a look at services compile checks, particularly the CGroups setup, to see if we can improve this by using their action code/setup as a model. We might also want to include module checks (from the same reference), as a way to ensure the module setup remains clean and consistent. |
95338d4
to
23ce3db
Compare
Yes. I did take a look at the services, and that specific workflow as a source of inspiration, however implementing everything in there is probably not necessary right now and out of scope of current task. But I agree that as the Codebase grows and in time, when we have many CI jobs we can use that model and refactor them all into a single CI WF. But for now, the objective of this CI Test is to protect the style guidelines. |
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description:
Add a CI Test that checks that the spotless check passes, otherwise it will fail and recommend to run the following command:
Related issue(s):
Fixes #31
Notes for reviewer:
Raised another PR with the same exact changes, but added another commit with a modification of style so to force the failure of the check.
see here:
#42
Checklist