refactor: 00029 refactor demo to lmax disruptor and 00055 persistence design doc #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattp-swirldslabs
force-pushed
the
00029-refactor-demo-disruptor
branch
from
552c9b9 to
582cfae
Compare
1 task
mattp-swirldslabs
force-pushed
the
00029-refactor-demo-disruptor
branch
3 times, most recently
from
6e392a8 to
e1c8b21
Compare
mattp-swirldslabs
force-pushed
the
00029-refactor-demo-disruptor
branch
3 times, most recently
from
fe67e8e to
b9ca958
Compare
AlfredoG87
changed the title
AlfredoG87
changed the title
mattp-swirldslabs
force-pushed
the
00029-refactor-demo-disruptor
branch
2 times, most recently
from
1860e91 to
67a942e
Compare
mattp-swirldslabs
force-pushed
the
00029-refactor-demo-disruptor
branch
4 times, most recently
from
9d1a28b to
3dd03b6
Compare
mattp-swirldslabs
changed the title
mattp-swirldslabs
force-pushed
the
00029-refactor-demo-disruptor
branch
from
714cad6 to
217188f
Compare
AlfredoG87
requested changes
Aug 6, 2024
server/src/main/java/com/hedera/block/server/BlockStreamService.java
Outdated
Show resolved
Hide resolved
server/src/main/java/com/hedera/block/server/BlockStreamService.java
Outdated
Show resolved
Hide resolved
server/src/test/java/com/hedera/block/server/consumer/ConsumerStreamResponseObserverTest.java
Outdated
Show resolved
Hide resolved
server/src/main/java/com/hedera/block/server/ServiceStatusImpl.java
Outdated
Show resolved
Hide resolved
server/src/main/java/com/hedera/block/server/mediator/LiveStreamMediatorImpl.java
Outdated
Show resolved
Hide resolved
mattp-swirldslabs
force-pushed
the
00029-refactor-demo-disruptor
branch
2 times, most recently
from
8f52ae3 to
2111430
Compare
mattp-swirldslabs
force-pushed
the
00029-refactor-demo-disruptor
branch
from
2111430 to
be78459
Compare
mattp-swirldslabs
force-pushed
the
00029-refactor-demo-disruptor
branch
from
be78459 to
4890c77
Compare
AlfredoG87
approved these changes
Aug 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #41 +/- ##
==============================================
+ Coverage 70.00% 100.00% +30.00%
- Complexity 33 110 +77
==============================================
Files 10 19 +9
Lines 170 420 +250
Branches 6 23 +17
==============================================
+ Hits 119 420 +301
+ Misses 47 0 -47
+ Partials 4 0 -4
|
mattp-swirldslabs
force-pushed
the
00029-refactor-demo-disruptor
branch
from
d305d33 to
fdd0f5c
Compare
- Integration with LMAX Disruptor RingBuffer - Changed toy types to align with names and relationships like hedera-protobufs - Boosted unit test coverage to 100% for most packages - Adjusted Docker container to run as the hedera user rather than root - Changed the consumer bidirection stream to server streaming - Added exception handling when reading and writing to storage - Refactored getBlock to singleBlock to align with hedera-protobufs rpc service definition and types - Separated ReadBlock and WriteBlock - Added RemoveBlock to handle removal of partially written Blocks when an exception is thrown - Adjusted producer and consumer scripts to work with new types - Added metrics to report: live block items counted, blocks persisted, single blocks retrieved and current subscribers Signed-off-by: Matt Peterson <[email protected]>
mattp-swirldslabs
force-pushed
the
00029-refactor-demo-disruptor
branch
from
fdd0f5c to
b40101b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
hedera-protobufs
bidirection streamtoserver streaminghedera-protobufsrpc service definition and typesRelated issue(s):
Fixes #29, #55
Notes for reviewer:
Checklist