docs: Design document for Block Verification Process #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlfredoG87
changed the title
AlfredoG87
added
Design
AlfredoG87
force-pushed
the
verification-design
branch
from
04ef762 to
6e49f24
Compare
| - **blocks_system_error**: Counter of the number of blocks with system errors | ||
| - **block_verification_time**: Histogram of the time taken to verify a block, gives the node operator an idea of the time taken to verify a block. | ||
| - | ||
| ## Exceptions |
There was a problem hiding this comment.
I think we're mingling high-level and detail design a bit too much, then.
A response code is what I would call these (as they are not exception classes) and avoid mingling concepts.
At this high level, it is irrelevant how that response code is generated (whether exception, or inspection, or any other mechanism); only that the response is returned to the "caller" (however that is defined).
jsync-swirlds
requested review from
jasperpotts,
georgi-l95,
ata-nas and
mattp-swirldslabs
ata-nas
reviewed
Dec 11, 2024
| - **blocks_system_error**: Counter of the number of blocks with system errors | ||
| - **block_verification_time**: Histogram of the time taken to verify a block, gives the node operator an idea of the time taken to verify a block. | ||
| - | ||
| ## Exceptions |
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
AlfredoG87
force-pushed
the
verification-design
branch
from
878c942 to
788be85
Compare
Signed-off-by: Alfredo Gutierrez <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #384 +/- ##
=========================================
Coverage 96.96% 96.96%
Complexity 395 395
=========================================
Files 79 79
Lines 1417 1417
Branches 93 93
=========================================
Hits 1374 1374
Misses 32 32
Partials 11 11 |
mattp-swirldslabs
approved these changes
Dec 13, 2024
ata-nas
reviewed
Dec 16, 2024
|
|
||
| ## Entities | ||
|
|
||
| - #### VerificationHandler |
There was a problem hiding this comment.
Wrong heading level for verification handler
Suggested change
| - #### VerificationHandler | |
| - ### VerificationHandler |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Design document for Block Verification Process
Related issue(s):
Fixes #383
Notes for reviewer:
Checklist