-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Update release-automation.yaml to enable completion #236
Merged
rbarkerSL
merged 4 commits into
main
from
235-investigate-and-fix-release-automation-flow
Oct 9, 2024
Merged
ci: Update release-automation.yaml to enable completion #236
rbarkerSL
merged 4 commits into
main
from
235-investigate-and-fix-release-automation-flow
Oct 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Description**: Uses the newly added GPG_KEY_CONTENTS, GPG_KEY_PASSPHRASE, and GH_ACCESS_TOKEN github actions secrets to enable the workflow to run. **Related Issue(s)**: Related to: #235 Signed-off-by: Roger Barker <[email protected]>
Signed-off-by: Roger Barker <[email protected]>
Signed-off-by: Roger Barker <[email protected]>
Signed-off-by: Roger Barker <[email protected]>
2 tasks
AlfredoG87
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thank you very much!! 💯
Looks good! |
andrewb1269hg
approved these changes
Oct 9, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #236 +/- ##
=========================================
Coverage 99.66% 99.66%
Complexity 247 247
=========================================
Files 50 50
Lines 903 903
Branches 61 61
=========================================
Hits 900 900
Misses 3 3 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Uses the newly added GPG_KEY_CONTENTS, GPG_KEY_PASSPHRASE, and GH_ACCESS_TOKEN github actions secrets to enable the workflow to run.
Related Issue(s):
Fixes: #235
Fixes: #229
Testing:
See the v99.99.99-draft workflow run which completes successfully