-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add additional metrics #164
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattp-swirldslabs
added
Improvement
Code changes driven by non business requirements
P2
Required to be completed in the assigned milestone, but may or may not impact release schedule.
labels
Sep 3, 2024
mattp-swirldslabs
changed the title
00149 additional metrics
feat: add additional metrics
Sep 3, 2024
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
…gging Signed-off-by: Matt Peterson <[email protected]>
mattp-swirldslabs
force-pushed
the
00149-addl-metrics
branch
from
September 3, 2024 16:35
b373c30
to
c0c03be
Compare
AlfredoG87
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #164 +/- ##
===========================================
Coverage 100.00% 100.00%
+ Complexity 135 133 -2
===========================================
Files 26 27 +1
Lines 511 535 +24
Branches 27 29 +2
===========================================
+ Hits 511 535 +24
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Improvement
Code changes driven by non business requirements
P2
Required to be completed in the assigned milestone, but may or may not impact release schedule.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue(s):
Closes #149 , #150 , #151
Notes for reviewer:
Checklist