-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Dagger for Dependency Injection Framework #118
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few items that could be improved, and a couple of questions.
buildSrc/src/main/kotlin/com.hedera.block.jpms-modules.gradle.kts
Outdated
Show resolved
Hide resolved
server/src/main/java/com/hedera/block/server/BlockNodeAppInjectionComponent.java
Show resolved
Hide resolved
server/src/main/java/com/hedera/block/server/health/HealthServiceImpl.java
Show resolved
Hide resolved
server/src/main/java/com/hedera/block/server/exception/UnhandledIOException.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
…UnhandledIOException that is a runtime wrapper for the checked IOException Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Last Changes was only rebase and conflict resolutions, in jpms gradle file, Server.java, BlockNodeApp.java files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, we'll fix the codecov in part 2
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #118 +/- ##
=============================================
- Coverage 100.00% 93.90% -6.10%
- Complexity 121 122 +1
=============================================
Files 21 23 +2
Lines 492 525 +33
Branches 27 27
=============================================
+ Hits 492 493 +1
- Misses 0 32 +32
|
Description:
Related issue(s):
Fixes #110
Notes for reviewer:
We did not perform a Unit test for new class
BlockNodeApp
since we need to wait for all other dependencies to be injected using Dagger, so we can mock them and also inject mocks when doing a UT for that class.Checklist