Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Smoke test #113

Merged
merged 10 commits into from
Aug 23, 2024
Merged

test: Smoke test #113

merged 10 commits into from
Aug 23, 2024

Conversation

AlfredoG87
Copy link
Contributor

@AlfredoG87 AlfredoG87 commented Aug 15, 2024 •
edited
Loading

Description:

  • Add a new CI that performs a Smoke-Test on the BlockNode Server
  • Adds 2 new scripts that are leveraged in order to perform the smoke-test:
    • get-block.sh
    • smoke-test.sh

Related issue(s):

Fixes #109

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@AlfredoG87 AlfredoG87 changed the title Smoke test test: Smoke test Aug 15, 2024
@AlfredoG87 AlfredoG87 self-assigned this Aug 15, 2024
@AlfredoG87 AlfredoG87 added the P1 High priority issue. Required to be completed in the assigned milestone. label Aug 15, 2024
@AlfredoG87 AlfredoG87 added this to the 0.1.0 milestone Aug 15, 2024
@AlfredoG87 AlfredoG87 changed the base branch from main to healthz-endpoints August 16, 2024 01:51
@AlfredoG87 AlfredoG87 marked this pull request as ready for review August 16, 2024 15:59
@AlfredoG87 AlfredoG87 requested review from a team as code owners August 16, 2024 15:59
mattp-swirldslabs
mattp-swirldslabs previously approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@mattp-swirldslabs mattp-swirldslabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for adding this. I think we'll see a lot of benefit.

server/src/test/resources/smoke-test.sh Show resolved Hide resolved
server/src/test/resources/smoke-test.sh Show resolved Hide resolved
Base automatically changed from healthz-endpoints to main August 16, 2024 22:22
@AlfredoG87 AlfredoG87 dismissed mattp-swirldslabs’s stale review August 16, 2024 22:22

The base branch was changed.

@AlfredoG87 AlfredoG87 requested a review from a team as a code owner August 16, 2024 22:22
@AlfredoG87 AlfredoG87 requested a review from dalvizu August 16, 2024 22:22
@AlfredoG87
Adding Started Log Message
176fa9f 
Signed-off-by: Alfredo Gutierrez <[email protected]>
@AlfredoG87
Added HealthService interface and its implementation, unit test and i…
13cff89 
…ntegration with Server

Signed-off-by: Alfredo Gutierrez <[email protected]>
@AlfredoG87
Adding CI Check for Runtime issues, created a smoke-test script for v…
7c6f84a 
…erifying that everything works as expected.

Signed-off-by: Alfredo Gutierrez <[email protected]>
@AlfredoG87
Fix moving the logs to file.
bbfe7bd 
Signed-off-by: Alfredo Gutierrez <[email protected]>
@AlfredoG87
fixes issues
a0524d5 
Signed-off-by: Alfredo Gutierrez <[email protected]>
mattp-swirldslabs
mattp-swirldslabs approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@mattp-swirldslabs mattp-swirldslabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlfredoG87 AlfredoG87 closed this Aug 19, 2024
@AlfredoG87 AlfredoG87 reopened this Aug 19, 2024
@AlfredoG87
update runs-on
b3d7cde 
Signed-off-by: Alfredo Gutierrez <[email protected]>
@AlfredoG87
update health to healthz endpoints
999d4b3 
Signed-off-by: Alfredo Gutierrez <[email protected]>
@AlfredoG87
removing extra unneeded char
68abcd4 
Signed-off-by: Alfredo Gutierrez <[email protected]>
@AlfredoG87
improved wording of healthz endpoints
e1c3bf2 
Signed-off-by: Alfredo Gutierrez <[email protected]>
mattp-swirldslabs
mattp-swirldslabs approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@mattp-swirldslabs mattp-swirldslabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlfredoG87 AlfredoG87 merged commit f148832 into main Aug 23, 2024
8 checks passed
@AlfredoG87 AlfredoG87 deleted the smoke-test branch August 23, 2024 21:14
@codecov Codecov
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (90dd282) to head (e1c3bf2).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff             @@
##                main      #113   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       114       121    +7     
===========================================
  Files             21        22    +1     
  Lines            430       446   +16     
  Branches          25        25           
===========================================
+ Hits             430       446   +16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbarkerSL rbarkerSL rbarkerSL approved these changes

@mattp-swirldslabs mattp-swirldslabs mattp-swirldslabs approved these changes

@georgi-l95 georgi-l95 georgi-l95 approved these changes

@jeromy-cannon jeromy-cannon jeromy-cannon approved these changes

@tomzhenghedera tomzhenghedera Awaiting requested review from tomzhenghedera tomzhenghedera was automatically assigned from hashgraph/release-engineering

@leninmehedy leninmehedy Awaiting requested review from leninmehedy leninmehedy is a code owner automatically assigned from hashgraph/release-engineering-managers

@dalvizu dalvizu Awaiting requested review from dalvizu dalvizu is a code owner automatically assigned from hashgraph/devops-ci

Assignees

@AlfredoG87 AlfredoG87

Labels
P1 High priority issue. Required to be completed in the assigned milestone.
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.

Smoke test in CI
5 participants
@AlfredoG87 @jeromy-cannon @georgi-l95 @mattp-swirldslabs @rbarkerSL