Skip to content

Commit

Permalink
fixing linting issues and returning check for changes on charts
Browse files Browse the repository at this point in the history
Signed-off-by: Alfredo Gutierrez <[email protected]>
  • Loading branch information
AlfredoG87 committed Jul 31, 2024
1 parent bfb76ee commit afff67d
Show file tree
Hide file tree
Showing 2 changed files with 30 additions and 16 deletions.
35 changes: 25 additions & 10 deletions .github/workflows/helm-charts.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,18 @@
##
# Copyright (C) 2024 Hedera Hashgraph, LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
##
name: Lint and Test Charts

on: pull_request
Expand Down Expand Up @@ -29,22 +44,22 @@ jobs:
- name: Set up chart-testing
uses: helm/chart-testing-action@e6669bcd63d7cb57cb4380c33043eebe5d111992 # v2.6.1

#- name: Run chart-testing (list-changed)
# id: list-changed
# run: |
# changed=$(ct list-changed --target-branch ${{ github.event.repository.default_branch }})
# if [[ -n "$changed" ]]; then
# echo "changed=true" >> "$GITHUB_OUTPUT"
# fi
- name: Run chart-testing (list-changed)
id: list-changed
run: |
changed=$(ct list-changed --target-branch ${{ github.event.repository.default_branch }})
if [[ -n "$changed" ]]; then
echo "changed=true" >> "$GITHUB_OUTPUT"
fi
- name: Run chart-testing (lint)
# if: steps.list-changed.outputs.changed == 'true'
if: steps.list-changed.outputs.changed == 'true'
run: ct lint --target-branch ${{ github.event.repository.default_branch }}

- name: Create kind cluster
# if: steps.list-changed.outputs.changed == 'true'
if: steps.list-changed.outputs.changed == 'true'
uses: helm/[email protected]

- name: Run chart-testing (install)
# if: steps.list-changed.outputs.changed == 'true'
if: steps.list-changed.outputs.changed == 'true'
run: ct install --target-branch ${{ github.event.repository.default_branch }}
11 changes: 5 additions & 6 deletions charts/hedera-block-node/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -73,14 +73,13 @@ tolerations: []
affinity: {}

blockNode:
version: "" # if blank will use same as AppVersion of chart.
# if blank will use same as AppVersion of chart.
version: ""
config:
# Add any additional env configuration here
# key: value
BLOCKNODE_STORAGE_ROOT_PATH: "/app/storage"
secret:
PRIVATE_KEY_TYPE: "ED25519" # ED25519 or ECDSA
PRIVATE_KEY_ENCODING: "HEX" # HEX or DER
PRIVATE_KEY_ACCOUNT_ID: "0.0.0" # Hedera account ID
PRIVATE_KEY: "fake_private_key" # Hedera account private key, format depends on encoding
HEDERA_NETWORK: "testnet" # testnet, previewnet or mainnet
# if blank will use same as AppVersion of chart.
PRIVATE_KEY: "fake_private_key"

Check failure on line 85 in charts/hedera-block-node/values.yaml

View workflow job for this annotation

GitHub Actions / lint-test

85:1 [empty-lines] too many blank lines (1 > 0)

0 comments on commit afff67d

Please sign in to comment.