Skip to content

Commit

Permalink
fix: code review changes
Browse files Browse the repository at this point in the history
Signed-off-by: Matt Peterson <[email protected]>
  • Loading branch information
mattp-swirldslabs committed Aug 21, 2024
1 parent cd5568f commit 7577bde
Show file tree
Hide file tree
Showing 7 changed files with 8 additions and 10 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/pr-checks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -72,13 +72,15 @@ jobs:
- name: Build
id: gradle-build
run: ${GRADLE_EXEC} build

- name: Style Check
id: spotless-check
run: ${GRADLE_EXEC} spotlessCheck

- name: Unit Tests
id: unit-tests
run: ${GRADLE_EXEC} check

- name: Upload coverage report
uses: codecov/codecov-action@e28ff129e5465c2c0dcc6f003fc735cb6ae0c673 # v4.5.0
with:
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/release-push-image.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,8 @@ jobs:
java-version: 21

- name: Build
run: ./gradlew clean build -x :stream:test # TODO: Remove -x :stream:test when PBJ bug is fixed
run: ./gradlew clean build

- name: Login to GitHub Container Registry
uses: docker/login-action@0d4c9c5ea7693da7b068278f7b52bda2a190a446 # v3.2.0
with:
Expand Down
2 changes: 1 addition & 1 deletion server/src/test/resources/consumer.sh
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,4 @@ grp_pid=$!
echo "Started consumer with PID: $grp_pid"

# Wait for the background process to complete
wait "$grp_pid"
wait "$grp_pid"
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@
"block": -1
}
}
}
}
2 changes: 1 addition & 1 deletion server/src/test/resources/templates/event_template.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@
}
}
}
}
}
2 changes: 1 addition & 1 deletion server/src/test/resources/templates/header_template.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@
}
}
}
}
}
5 changes: 0 additions & 5 deletions settings.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,3 @@ buildCache {
}
}
}

fun include(name: String, path: String) {
include(name)
project(name).projectDir = File(rootDir, path)
}

0 comments on commit 7577bde

Please sign in to comment.