fix: replaced containsKey check with remove

Signed-off-by: Matt Peterson <[email protected]>
hashgraph · Aug 4, 2024 · 7066a7a · 7066a7a
1 parent d26b0ac
commit 7066a7a
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/server/src/main/java/com/hedera/block/server/mediator/LiveStreamMediatorImpl.java b/server/src/main/java/com/hedera/block/server/mediator/LiveStreamMediatorImpl.java
@@ -152,18 +152,17 @@ public void subscribe(final EventHandler<ObjectEvent<SubscribeStreamResponse>> h
     public void unsubscribe(final EventHandler<ObjectEvent<SubscribeStreamResponse>> handler) {
 
         // Remove the subscriber
-        if (subscribers.containsKey(handler)) {
+        final var batchEventProcessor = subscribers.remove(handler);
+        if (batchEventProcessor == null) {
+            LOGGER.log(System.Logger.Level.ERROR, "Subscriber not found: {0}", handler);
 
-            final var batchEventProcessor = subscribers.remove(handler);
+        } else {
 
             // Stop the processor
             batchEventProcessor.halt();
 
             // Remove the gating sequence from the ring buffer
             ringBuffer.removeGatingSequence(batchEventProcessor.getSequence());
-
-        } else {
-            LOGGER.log(System.Logger.Level.ERROR, "Subscriber not found: {0}", handler);
         }
     }