Missing key strings in plist required for uploading to App connect #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imashok02
requested review from
rampr,
schnhegde,
afkcodes,
vyshnavsdeepak,
nasimafeef,
ramizbalayil,
nautyvaibhav and
anil-kumar07
rampr
reviewed
Oct 17, 2019
Comment on lines
+78
to
+83
| <key>NSPhotoLibraryUsageDescription</key> | ||
| <string>This app requires access to the photo library.</string> | ||
| <key>NSLocationAlwaysUsageDescription</key> | ||
| <string>This app requires access to your location.</string> | ||
| <key>NSLocationWhenInUseUsageDescription</key> | ||
| <string>This app requires access to your location.</string> |
There was a problem hiding this comment.
It is better to move it to the plugin that requires these permissions
There was a problem hiding this comment.
Will have to find the app which uses this permissions, Do we need to do now? Also I guess we dont need location permission.. right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.