add DirectPost support & upgrade meson version #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
Mikerah
requested changes
Sep 28, 2023
cmd/wallet/wallet.toml
Outdated
| @@ -1,4 +1,4 @@ | |||
| KSLocation = "/tmp/meson-wallet/keystore" | |||
| KSLocation = "/Users/liaoyuchen/Developer/Meson-wallet-demo/keystore" | |||
There was a problem hiding this comment.
Change the location of this since this is unique to your own machine
cmd/wallet/wallet.toml
Outdated
| @@ -15,7 +15,7 @@ DefaultChainID = 5 | |||
| [Meson] | |||
| [Meson.Logging] | |||
| Disable = false | |||
| File = "/tmp/meson-wallet/wallet.log" | |||
| File = "/Users/liaoyuchen/Developer/Meson-wallet-demo/wallet.log" | |||
sc0Vu
reviewed
Oct 14, 2023
| }) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| req := common.NewRequest(command.EthQuery, w.Ticker(chainID), payload).ToJson() | ||
| req := common.NewRequest(0x01, w.Ticker(chainID), payload).ToJson() |
There was a problem hiding this comment.
@LYC386 IMHO, it might be better to use command.DirectPost.
sc0Vu
reviewed
Oct 14, 2023
| if err != nil { | ||
| return "", err | ||
| } | ||
| req := common.NewRequest(command.PostTransaction, w.Ticker(tx.ChainId().Int64()), payload).ToJson() | ||
| req := common.NewRequest(0x01, w.Ticker(tx.ChainId().Int64()), payload).ToJson() |
There was a problem hiding this comment.
also you might want to change the comment
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates FillTx and SendTx function to support querying gas and sending tx using DirectPost command.
Corresponds to Meson PR.
Updates Meson version