Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add tests for public appeal #903

Merged
merged 2 commits into from
Nov 3, 2024
Merged

test: add tests for public appeal #903

merged 2 commits into from
Nov 3, 2024

Conversation

YaelChen
Copy link
Collaborator

@YaelChen YaelChen commented Nov 3, 2024

Description

Public Appeal menue item should lead to "קול קורא" and its link inside should lead to the Docs page in Hasadna site.

@YaelChen YaelChen requested a review from ShayAdler November 3, 2024 10:35
@YaelChen YaelChen requested a review from NoamGaash as a code owner November 3, 2024 10:35
tests/publicAppeal.spec.ts Fixed Show fixed Hide fixed
@YaelChen
Copy link
Collaborator Author

YaelChen commented Nov 3, 2024

I actually run lint:fix this time... after lunch I'll try to check what did I miss now :)

@NoamGaash NoamGaash changed the title add tests for public appeal test: add tests for public appeal Nov 3, 2024
Copy link
Member

@NoamGaash NoamGaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thanks!
I've changed the pull request title so the pr title lint will pass.
Having the test: prefix let's us know that this PR does not introduce a new feature or bug fix that should appear in the changelog and the release notes

Thank you for your help with maintaining the test suit 💪

here you can read more about commit (/pr title) conventions

@NoamGaash
Copy link
Member

@all-contributors please add @YaelChen as code and tests contributor

Copy link
Contributor

@NoamGaash

I've put up a pull request to add @YaelChen! 🎉

@YaelChen YaelChen merged commit 1bbea85 into main Nov 3, 2024
15 of 16 checks passed
@YaelChen YaelChen deleted the publicAppealTest branch November 3, 2024 13:41
@NoamGaash
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants