fix: rides history page #867
Conversation
NoamGaash
changed the title
src/api/gtfsService.ts
Outdated
| const maxEndTime = Math.max(...rides.map((ride) => Number(ride.endTime))) | ||
| const minStartTime = Math.min(...rides.map((ride) => Number(ride.startTime))) |
There was a problem hiding this comment.
just an idea - sometimes the actual ride happen before / after this range. maybe we should consider something like -
| const maxEndTime = Math.max(...rides.map((ride) => Number(ride.endTime))) | |
| const minStartTime = Math.min(...rides.map((ride) => Number(ride.startTime))) | |
| const timeMargin = 1000 * 60 * 60 * 1.5 // 1.5 hours | |
| const maxEndTime = Math.max(...rides.map((ride) => Number(ride.endTime))) + timeMargin | |
| const minStartTime = Math.min(...rides.map((ride) => Number(ride.startTime))) + timeMargin |
There was a problem hiding this comment.
Thanks for the quick response. I fixed the linter issues, added the correct type and added error & empty data error "handling" (can be improved) and submitted before seeing your replies. Would you like me to incorporate your suggestion and create another commit?
There was a problem hiding this comment.
It's up to you, it was just a suggestion.
Thanks for fixing the lint issues!
|
|
||
| return stopHits.sort((hit1, hit2) => +hit1.arrivalTime! - +hit2.arrivalTime!) | ||
| } catch (error) { | ||
| console.error(`Error fetching stop hits:`, error) |
There was a problem hiding this comment.
nice. I guess we can use some error boundary component to render a meaning full error message to the user
src/api/gtfsService.ts
Outdated
| const maxEndTime = Math.max(...rides.map((ride) => Number(ride.endTime))) | ||
| const minStartTime = Math.min(...rides.map((ride) => Number(ride.startTime))) |
There was a problem hiding this comment.
It's up to you, it was just a suggestion.
Thanks for fixing the lint issues!
|
Thank you! |
|
I've put up a pull request to add @TomRytt! 🎉 |
Description
Fixes issue #856 by adding the required "arrival_time_from" and "arrival_time_to" fields to the gtfs_ride_stops api call.
Changed the previous api call which utilized the gtfsAPI to an axios call directly to the server with the required data since the gtfsAPI whitelisted the required fields mentioned above which caused the api call to fail.
Still requires futher optimizations since the request is very slow and tests need to be written in future issues.
@NoamGaash