feat: add Donation Modal as menu item #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a Donation Modal that opens when the donation menu item is clicked. - Created a `DonateModal` component based on the existing `DonationButton`. - Updated `MainMenu` to include a conditional check for the donation menu item. - Used `e.preventDefault()` to prevent URL change when the donation menu item is clicked. - Integrated the `DonateModal` into the `MainMenu` component.
NoamGaash
approved these changes
Jun 22, 2024
There was a problem hiding this comment.
Can we make the donation button use the same donation modal component?
Let's avoid code duplication where it's possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution for #422
Description
Added a Donation Modal that opens when the donation menu item is clicked.
Created a
DonateModalcomponent based on the existingDonationButton.Updated
MainMenuto include a conditional check for the donation menu item.Used
e.preventDefault()to prevent URL change when clicking the donation menu item.Integrated the
DonateModalinto theMainMenucomponent.Ensured that donation links in the modal open in a new tab.
screenshots