Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: create contribution.md file #324

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Conversation

NoamGaash
Copy link
Member

Description

close #194

@NoamGaash NoamGaash requested a review from shootermv December 17, 2023 20:42
@amabelleS
Copy link
Collaborator

Maybe we should also include somthing like this:

How should I write my commits?

link to the Git Commit Guidelines

I don't know how much it's relevant to #320
It could be in another issue.

@shootermv
Copy link
Contributor

shootermv commented Dec 18, 2023

@amabelleS you totally right -
commit messages convention it is something that should be in the contribution guide
one more point worth to add to the guide - how to keep history clean when merging (or - how to merge PRs)

This will help a lot to new contributors, how to keep history clean when merging. I'm afraid I'm not following any conventions now, and will love to learn best practices as well:)

@NoamGaash
Copy link
Member Author

NoamGaash commented Dec 18, 2023

@amabelleS @shootermv I won't do it in this PR.
If you don't approve this, let's close it and delete that branch.

I totally approve of this PR, great contribution:) Sorry I was not clear, it was just my way of saying, that maybe we need to add this too, not sure if and where.

@shootermv
Copy link
Contributor

@NoamGaash of course, i didnt mean everything should be in the same Pr

@NoamGaash NoamGaash merged commit 76893de into main Dec 18, 2023
14 checks passed
@NoamGaash NoamGaash deleted the docs/create-contribution.md-file branch December 18, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create CONTRIBUTION.md file
3 participants