refactor: removing texts (part 6)

[amabelleS]

Description

Removed from pointTypeToDescription - Notice - I did import { t } from 'i18next'. because I used it in an object, not react component.

DELETED texts.ts!

[github-actions]

Preview: https://s3.amazonaws.com/noam-gaash.co.il/7244826891/open-bus/0129788a3da5088d619b0b694c2a095d27cdcb66/index.html
Preview Storybook: https://s3.amazonaws.com/noam-gaash.co.il/7244826891/open-bus/0129788a3da5088d619b0b694c2a095d27cdcb66/storybook/index.html

[NoamGaash]

thanks for this PR!
I believe we don't really need the translation module in this file, would you consider removing it?

[NoamGaash]

Suggested change

	const timeDisplay = timestamp.format(t('time_format'))
	const timeDisplay = timestamp.format('time_format')

[amabelleS]

Here we can pass the time format directly = HH:mm:ss. If we pass it like 'time_format' this is what we get:

I think I have seen use of the translation modal in another place, for formatting time. If so maybe it should be a constant somewhere.

[NoamGaash]

well, it's weird to find it in the translation file, you're right. it can simply be a constant

[NoamGaash]

Suggested change

	[PointType.GTFS]: t('timestamp_gtfs'),
	[PointType.SIRI]: t('timestamp_siri'),
	[PointType.TARGET]: t('timestamp_target'),
	[PointType.GTFS]: 'timestamp_gtfs',
	[PointType.SIRI]: 'timestamp_siri',
	[PointType.TARGET]: 'timestamp_target',

[amabelleS]

Here I think we need the translation modal, this is the result if we remove it from the first two:

[NoamGaash]

Suggested change

import { t } from 'i18next'

[amabelleS]

I did not remove the i18next modal, because I'm still using it in pointTypeToDescription.

[NoamGaash]

@amabelleS please consider this change #321