Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: useVehicleLocation cache mechanism #295

Merged
merged 1 commit into from
Dec 13, 2023
Merged

fix: useVehicleLocation cache mechanism #295

merged 1 commit into from
Dec 13, 2023

Conversation

giladfuchs
Copy link
Collaborator

slove #292

Description

just easy way by add to observable key
operatorRef lineRef

for getting new time from server

@giladfuchs
add for key at getLocations
2bbd705 
operatorRef lineRef

for getting new time from server
@giladfuchs giladfuchs changed the title add for key at getLocations slove #292 Dec 13, 2023
NoamGaash
NoamGaash approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@NoamGaash NoamGaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code looks great, did you test it's working as expected on both maps? (single line and realtime)

@NoamGaash NoamGaash linked an issue Dec 13, 2023 that may be closed by this pull request
[Bug] Map showing only the first line that was chosen #292
Closed
@NoamGaash NoamGaash changed the title slove #292 fix: useVehicleLocation cache mechanism Dec 13, 2023
@giladfuchs
Copy link
Collaborator Author

the code looks great, did you test it's working as expected on both maps? (single line and realtime)

yes

@giladfuchs giladfuchs merged commit bd902de into main Dec 13, 2023
9 checks passed
@giladfuchs giladfuchs deleted the fix-change-line branch December 13, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoamGaash NoamGaash NoamGaash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Map showing only the first line that was chosen
2 participants
@giladfuchs @NoamGaash