Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: easter language toggle #289

Merged
merged 6 commits into from
Dec 14, 2023
Merged

feat: easter language toggle #289

merged 6 commits into from
Dec 14, 2023

Conversation

NoamGaash
Copy link
Member

Description

type "english" to see the language toggle button.
it's temporary - once the english texts will be approved, we will release it without a secret code.

@NoamGaash NoamGaash requested a review from shootermv December 12, 2023 06:38
Copy link
Contributor

@shootermv shootermv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job!

src/layout/sidebar/menu/Menu.tsx Outdated Show resolved Hide resolved
@NoamGaash NoamGaash requested a review from shootermv December 12, 2023 21:16
@shootermv
Copy link
Contributor

after thinking about more about the this change...
may be it can be good to split this language toggle change - to spaller subPoints

@NoamGaash
Copy link
Member Author

sub components?

@NoamGaash NoamGaash merged commit a9caac9 into main Dec 14, 2023
9 checks passed
@NoamGaash NoamGaash deleted the feat/easter-language-toggle branch December 14, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants