Removing texts part c#161 #284
Conversation
| @@ -94,5 +94,7 @@ | |||
| "bug_type_message":"Please enter the type of request", | |||
| "bug_type_bug":"Bug", | |||
| "bug_type_feature":"Feature Request", | |||
| "funding_paragraph": "The Databus project is developed by the Hasadna for public knowledge, by the contributions of volunteers, and based upon" | |||
| "funding_paragraph": "The Databus project is developed by the Hasadna for public knowledge, by the contributions of volunteers, and based upon", | |||
There was a problem hiding this comment.
Space removed by purpose?
No. Maybe Lint complained, but I can't even see what space we are talking about... just that there is a change in "funding_paragraph" that I did not mean to make.
| @@ -64,6 +39,32 @@ const GapsPage = () => { | |||
| const [gapsIsLoading, setGapsIsLoading] = useState(false) | |||
| const [onlyGapped, setOnlyGapped] = useSessionStorage('onlyGapped', false) | |||
|
|
|||
| function formatTime(time: Moment) { | |||
There was a problem hiding this comment.
Why did you move it inside the component?
There was a problem hiding this comment.
Why did you move it inside the component?
I feel ashamed about why, and I am trying to think of another solution.
You can call t / const { t } = useTranslation() outside of a react component because it is a hook. So I moved the functions that use t inside of the react component function. Very dirty, I need a shower now:)
There was a problem hiding this comment.
Oh, you're right. Its not dirty - I just didn't expect moving the time format to the translation file
Description
Removed from: FilterPositionsByStartTimeSelector, GapsPage, DisplayGapsPercentage, DateSelector, and TimelinePage.