Removing texts part b#161

[amabelleS]

Description

Removed from: GitHubLink & BugReportFormData.

** Next, src>routes.tsx, but we need to implement the PAGES array differently because we can't use a hook outside of a component **

screenshots

GitHubLink

BugReportFormData

EDIT

Meanwhile, I started working on routes.tsx. Pls check the proposal changes I made, and if approved I'll continue.
The idea is to replace the PAGES array with the getPages function:

export const getPages = () => {
  const { t } = useTranslation()
  return [
    {
      label: t('dashboard_page_title'),
      path: '/dashboard',
      icon: <LaptopOutlined />,
      element: <DashboardPage />,
    },
    {
      label: t('timeline_page_title'),
      path: '/timeline',
      searchParamsRequired: true,
      icon: <FieldTimeOutlined />,
      element: <TimelinePage />,
    },
    {
      label: t('gaps_page_title'),
      path: '/gaps',
      searchParamsRequired: true,
      icon: <BarChartOutlined />,
      element: <GapsPage />,
    },
    {
      label: t('gaps_patterns_page_title'),
      path: '/gaps_patterns',
      icon: <LineChartOutlined />,
      element: <GapsPatternsPage />,
    },
    {
      label: t('realtime_map_page_title'),
      path: '/map',
      icon: <HeatMapOutlined />,
      element: <RealtimeMapPage />,
    },
    {
      label: t('singleline_map_page_title'),
      path: '/single-line-map',
      searchParamsRequired: true,
      icon: <RadarChartOutlined />,
      element: <SingleLineMapPage />,
    },
    {
      label: t('about_title'),
      path: '/about',
      icon: <BellOutlined />,
      element: <About />,
    },
    {
      label: t('report_a_bug_title'),
      path: 'report-a-bug',
      icon: <BugOutlined />,
      element: <BugReportForm />,
    },
    {
      label: t('donate_title'),
      path: 'https://www.jgive.com/new/he/ils/donation-targets/3268#donation-modal',
      icon: <DollarOutlined />,
      element: null,
    },
  ]
}

Also important:

I noticed that the "old" translation of "dashboard_page_title" in text.tsx is: 'מפעילי תח"צ לפי קיום נסיעות מתוכננות'
But the new one in he.json is: 'קיום נסיעות'

Is is on purpose?

[NoamGaash]

Good job 💪
I've made some suggestions

[NoamGaash]

Please delete the commented line

[NoamGaash]

Please remove

[NoamGaash]

Suggested change

	export const getPages = () => {
	export const usePages = () => {

Every function that calls react hook is a hook

[NoamGaash]

Can you delete it?

First I need to remove all references to it, there are still some changes to make to replace the implementations of PAGES with the new usePages hook.
So I'll make the changes and ask again for a review for this PR, one that will complete the removal of TEXT_KEYS from routes.tsx.

Thx a lot for your suggestions, on it:)

[NoamGaash]

Must be called outside this function, because it's a hook

[amabelleS]

Must be called outside this function, because it's a hook

If you move usePages outside of a react component, you get this warning:
index.tsx:29 Warning: Invalid hook call. Hooks can only be called inside of the body of a function component.

I think I misunderstood you or something on this one:)

[NoamGaash]

My bad, it should be inside the component, you're right ✅

[shootermv]

looks very good to me
מפעילי תח"צ לפי קיום נסיעות מתוכננות - was something seemed hard to understand
i replaced it by קיום נסיעות
in order to make it more easy understand
but now, i think m- may be it can be better to replace it with
ביצועי תחבורה- מבט כללי

[amabelleS]

looks very good to me מפעילי תח"צ לפי קיום נסיעות מתוכננות - was something seemed hard to understand i replaced it by קיום נסיעות in order to make it more easy understand but now, i think m- may be it can be better to replace it with ביצועי תחבורה- מבט כללי

for the he.json.
And for en.json: "Public transport operators - overview" ?

I tried to put it in this PR, but the validate/test failed, so I changed it back...

[NoamGaash]

@amabelleS feel free to edit the tests if you want to :)

I'll put it in my next PR, changing to "Overview" / "מבט כללי" :)

[shootermv]

nice work!
thanks @amabelleS !