Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move layout logic to separate component #257

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

shootermv
Copy link
Contributor

@shootermv shootermv commented Nov 29, 2023

Description

in order to make App component shorter (now it is 140 lines)
i think it can be better to move all the layout stuff to separate layout component
This will make App component code shorter and cleaner

screenshots

not relevant here

@shootermv shootermv requested a review from NoamGaash as a code owner November 29, 2023 17:45
@shootermv shootermv merged commit 7e8c160 into main Nov 29, 2023
9 checks passed
@shootermv shootermv deleted the refactor-create-layout-component branch November 29, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants