Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Replace sort by date and remove reversed #237

Merged
merged 1 commit into from
Nov 21, 2023
Merged

fix: Replace sort by date and remove reversed #237

merged 1 commit into from
Nov 21, 2023

Conversation

moshefortgang
Copy link
Contributor

Description

Fix #235

@netlify Netlify
Copy link

netlify bot commented Nov 21, 2023 •
edited
Loading

✅ Deploy Preview for astonishing-pothos-5f81bd ready!

Name Link
🔨 Latest commit c91fdec
🔍 Latest deploy log https://app.netlify.com/sites/astonishing-pothos-5f81bd/deploys/655c87adc714fa00095d39d3
😎 Deploy Preview https://deploy-preview-237--astonishing-pothos-5f81bd.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@moshefortgang moshefortgang changed the title Replace sort by date and remove reversed #235 Replace sort by date and remove reversed Nov 21, 2023
@NoamGaash NoamGaash requested review from shootermv and ArkadiK94 and removed request for NoamGaash and shootermv November 21, 2023 12:26
ArkadiK94
ArkadiK94 approved these changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@ArkadiK94 ArkadiK94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work thanks for your contribution 👍

@ArkadiK94
Copy link
Collaborator

ArkadiK94 commented Nov 21, 2023 •
edited
Loading

@NoamGaash
image
Is it ok that this two boxes are not checked?

edit:
https://docs.netlify.com/site-deploys/notifications/#github-commit-checks
https://answers.netlify.com/t/how-to-disable-specific-checks-for-pull-requests/14568/2
would you like to remove the GitHub commit checks? or you prefer to have them for more info.

This question is not related to this pr, so I merge it.

@ArkadiK94 ArkadiK94 changed the title Replace sort by date and remove reversed fix: Replace sort by date and remove reversed Nov 21, 2023
@ArkadiK94 ArkadiK94 merged commit b43431b into hasadna:main Nov 21, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArkadiK94 ArkadiK94 ArkadiK94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@moshefortgang @ArkadiK94