Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #193: Profile page creation #203

Closed
wants to merge 6 commits into from
Closed

issue #193: Profile page creation #203

wants to merge 6 commits into from

Conversation

VSciFlight
Copy link
Contributor

Description

Added an empty space page for profile to be manifested in.
It is not shown on the sidebar menu and accessible only by reaching the link of /profile.

screenshots

image



* 'main' of https://github.com/VSciFlight/open-bus-map-search:
  Added Unit Test for Menu.tsx (#154)
  Added Localization support for About and Dashboard (#95)
  docs: update link to api repo at readme (#150)
  updated HbarChart style (#152)
  Reverse the timeline graph XAxis to be with  'ltr' orientation (#149)
  remove unnecessary console.log
  remove unnecessary console.log
  hotfix: operatorRefField (#142)
  [Bug] Fix GapsPatternsPage layout
  [Bug] Fix Dashboard Layout (also in Mobile)
  docs: better styling for testing instructions
  Test - use advanced HAR (#140)
  Add github lint workflow file (#141)
  Refactoring of the Sidebar component and its styling (#138)
  feat(useVehicleLocations): support operatorRef (#96)
  feat: auto complaint generation (#136)
  Create dependabot.yml (#135)
  Update package.json
  refactor: test commands
Copy link

netlify bot commented Nov 12, 2023

Deploy Preview for astonishing-pothos-5f81bd failed.

Name Link
🔨 Latest commit 87d838a
🔍 Latest deploy log https://app.netlify.com/sites/astonishing-pothos-5f81bd/deploys/655291e68fcef900086c3f2c

Copy link
Member

@NoamGaash NoamGaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice start!
Please resolve conflicts and comments 💪

src/App.tsx Outdated Show resolved Hide resolved
@NoamGaash
Copy link
Member

please see the linter and playwright test failures

@VSciFlight
Copy link
Contributor Author

Strange thing because it worked fine before the commit.
afterwards it got messy so I rebranched.

Fixed it now, suppose to work just fine and just upgraded it
closing this request and opening new relevant one.

@VSciFlight VSciFlight closed this Nov 13, 2023
@VSciFlight VSciFlight deleted the profile_page branch November 13, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants