Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: change mobile menu to use drawer #201

Merged
merged 2 commits into from
Nov 12, 2023
Merged

feat: change mobile menu to use drawer #201

merged 2 commits into from
Nov 12, 2023

Conversation

shootermv
Copy link
Contributor

Description

Closes #198

screenshots

open
image
closed
image

@shootermv shootermv requested a review from NoamGaash as a code owner November 12, 2023 12:41
@netlify Netlify
Copy link

netlify bot commented Nov 12, 2023 •
edited
Loading

✅ Deploy Preview for astonishing-pothos-5f81bd ready!

Name Link
🔨 Latest commit b6af4b2
🔍 Latest deploy log https://app.netlify.com/sites/astonishing-pothos-5f81bd/deploys/6550f8aa17c8020008ed1671
😎 Deploy Preview https://deploy-preview-201--astonishing-pothos-5f81bd.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

NoamGaash
NoamGaash approved these changes Nov 12, 2023
View reviewed changes
Copy link
Member

@NoamGaash NoamGaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! thank you

src/pages/components/header/sidebar/sidebar.scss Outdated Show resolved Hide resolved
@shootermv shootermv merged commit 34167c9 into main Nov 12, 2023
11 checks passed
@shootermv shootermv deleted the replace-menu-by-drawer-at-mobile branch November 12, 2023 16:12
@github-actions github-actions bot mentioned this pull request Dec 18, 2023
Merged
@github-actions github-actions bot mentioned this pull request Jun 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoamGaash NoamGaash NoamGaash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

replace menu by drawer at mobile
2 participants
@shootermv @NoamGaash